Ports unit test fix. Shortens CI time significantly. #12078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerfulBacon
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Optimizes area_contents.
Thanks Lemon.
Why It's Good For The Game
We've had an anchor strapped to our ankle for the past 17 months in the form of this awful unit test.
You ever get all the map workflows taking forever to go down their tests?
You ever get all the mapflows finish their tests on time but you have this one straggler not MOVING AT ALL for 12 minutes and it completely slows down the runners for EVERYONE?
Yea no thanks. <3
Testing Photographs and Procedure
Its very clear.
Before
After
Its not an exact science, but theres a tangible and empirical difference in the map times.
Changelog
🆑 rkz, LemonInTheDark
code: optimized a slow unit test. Speedup CI a lot.
/:cl: