Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute people can now make audible sounds again. #12083

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

XeonMations
Copy link
Contributor

About The Pull Request

Removes a check that was originally added in #11991 that checked if the screamer was mute, and if so, to mute them.

Why It's Good For The Game

Mute people should be able to scream and whistle audibly. They're not mimes, after all.

Testing Photographs and Procedure

Screenshots&Videos
2024-12-27.00-12-18.mp4

Changelog

🆑 XeonMations
fix: Mute people can now make audible sounds again.
/:cl:

@HowToLoLu
Copy link
Contributor

HowToLoLu commented Dec 26, 2024

I have a suggestion: perhaps instead of removing the check outright- replace it to check if the job of the mind is Mime so that at least mimes are silent

Nevermind I read the full check and mimes do have their own separate silenced variable in their mind which is checked here

@Rukofamicom Rukofamicom added this pull request to the merge queue Dec 28, 2024
Merged via the queue into BeeStation:master with commit 0294c42 Dec 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants