world.fps and SStimers safety check #9478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tsar-Salat
changed the title
itsmeow
approved these changes
Jul 22, 2023
|
This was technically an uncredited addition to #7285, which was later reverted for related issues. Needless to say, I think those changes are good, but we should individually check which ported pr of that actually broke the server |
Tsar-Salat
force-pushed
the
world.fps-feex
branch
from
b1f7925 to
3299a87
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
itsmeow
reviewed
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports:
About The Pull Request
if you actually change world.fps without a check like this you can have SStimer lists runtiming out of bounds, breaking a lot of things.
Why It's Good For The Game
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑 RKz, Rohesie
code: SStimers wont runtime out of bounds if you change world.fps
/:cl: