AFK players now show up as SSD on examine (+ soft ping port)

[Absolucy]

About The Pull Request

This makes it so that AFK players will appear as SSD. This uses the inactivity period configuration, which is 5 minutes by default.

Although perhaps a different message could be shown for AFK players as opposed to SSD players? I'm open to suggestions, I'm not that good at coming up with flavor text.

Also ports tgstation/tgstation#66299, which fixes inactivity/is_afk not working, as uh, that kinda needs to work for this.

Why It's Good For The Game

Makes it less likely for me to be killed when I'm AFK (but not disconnected) because I had to go use the bathroom or do some chores, due to someone not being able to tell I'm AFK when examining me.

Testing Photographs and Procedure

Screenshots&Videos

Soft-ping

AFK examine (+ working is_afk)

Changelog

🆑 Absolucy, stylemistake
add: AFK players will now have flavor text indicating that they're AFK when examined.
fix: AFK detection now works properly again.
/:cl:

[PowerfulBacon]

Why would we want to let players adjust how long until they are registered as being AFK? This should be a config setting and set entirely by the server.

[Absolucy]

Ah, fair. I'm not sure why I did that.

Should it be a separate config option or just the INACTIVITY_PERIOD config?

[PowerfulBacon]

oh yea, inactivity period is probably fine

[Absolucy]

Aight, I changed it to just use the default is_afk arguments, which is the inactivity period configured by the server.

[itsmeow]

This should also show on MedHUDs

[Absolucy]

@itsmeow like as in the "dead, distant soul" medhud?

[itsmeow]

the yellow question mark

[Absolucy]

@itsmeow done

[itsmeow]

You have to actually call medhud update status when the afk value changes or it won't actually show.

[Absolucy]

@itsmeow What'd be the best way to handle that? Since is_afk is polled, rather than being constantly checked...

[itsmeow]

Looks good.

addressed