Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Lazarus injector has a small bug + Lazarus QoL #9767

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

EvilDragonfiend
Copy link
Member

@EvilDragonfiend EvilDragonfiend commented Sep 1, 2023

About The Pull Request

Fixes Lazarus injector has a small bug

  • revived mob's faction can be unintentionally changed (for example, carps will lose carp faction)
  • revived hostile-mob without player occupation (but mind exists) will follow AI act to attack people
  • QOL, ghost notification.

Why It's Good For The Game

bug fix good

Testing Photographs and Procedure

image

Changelog

🆑
fix: Lazarus injector will not accidentally change faction status when it has a player mind.
fix: Mobs with player mind that are revived by Lazarus injector will have their AI status off, so that people will not be attacked randomly.
add: Lazarus injector will not revive a mob with an unrevivable mind. If it revives a mob, it will notify its ghost.
/:cl:

Comment on lines 32 to 33
else // only do this to mindless mobs
M.faction = list("neutral")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we only want to set the faction for mindless mobs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think it's better to remove

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is intended behaviour, to make the simple mob non agressive, mindless doesn't mean it has no AI

@EvilDragonfiend EvilDragonfiend changed the title Fixes Lazarus injector has a small bug Fixes Lazarus injector has a small bug + Lazarus QoL Sep 21, 2023
Copy link
Member

@Penwin0 Penwin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought the faction being set to neutral thing was on purpose, to make them non hostile anymore

@EvilDragonfiend
Copy link
Member Author

So, what do I do?

@Rukofamicom Rukofamicom added this pull request to the merge queue Nov 6, 2023
Merged via the queue into BeeStation:master with commit bd43212 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants