Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New station trait: Clown Bridge Access! #9797

Closed
wants to merge 10 commits into from

Conversation

Absolucy
Copy link
Contributor

@Absolucy Absolucy commented Sep 6, 2023

About The Pull Request

Inspired by this: image

This just adds a new negative trait, Clown Bridge Access, where the clown spawns with bridge access. Simple as that. Bridged clown IDs will have a special description. The clown will get a message upon joining telling them of their special access.

Why It's Good For The Game

It's funny :3

Testing Photographs and Procedure

Screenshots&Videos

23-09-06-1694024542-dreamseeker
23-09-06-1694024628-dreamseeker

Changelog

🆑
add: Adds a new (negative) station trait, where the clown spawns with bridge access! Honk!
/:cl:

@github-actions github-actions bot added the TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 label Sep 6, 2023
@Cartlord
Copy link

Cartlord commented Sep 6, 2023

is there any justifiction to this besides "funny"? i can't see how clowns ever having extra access (and therefore more space to rainbow-tide) would be a good thing.

@itsmeow
Copy link
Member

itsmeow commented Sep 6, 2023

low tier IC crime (e.g. trespass) is good for sec as it makes more confusion on who is antag and who isn't, and makes them actually look at space law

@Cartlord
Copy link

Cartlord commented Sep 7, 2023

How can you punish someone for trespassing into somewhere they have access to? How can you stop them from doing it again if you don't know how to work the ID console (i'm assuming it'd be powergaming for a security officer to use it) or the spare's been taken?

@itsmeow
Copy link
Member

itsmeow commented Sep 7, 2023

access is not authorization. using the ID console is not powergaming. and you can just ask the captain or HoP to do it.

@itsmeow
Copy link
Member

itsmeow commented Sep 7, 2023

Only problem with this is it may push clowns too far into self antag but i think it might be funny enough and make enough sense IC to be a rare thing

@MarkusLarsson421
Copy link
Contributor

This is dumb and I love it.

I only worry for low-pop when there is no Heads and only the Clown has easy access to the bridge. Might also encourage speed running the spare ID as an antagonistic Clown if the stars align (low-pop, antag, clown, bridge trait) which is already sometimes too easy.

@EvilDragonfiend
Copy link
Member

EvilDragonfiend commented Sep 15, 2023

This is dumb and I love it.

I only worry for low-pop when there is no Heads and only the Clown has easy access to the bridge. Might also encourage speed running the spare ID as an antagonistic Clown if the stars align (low-pop, antag, clown, bridge trait) which is already sometimes too easy.

maybe that's how the star alignment works... the day is coming.
and, but, still, there should be a clown willing to do that even during the alignment.

Copy link
Member

@EvilDragonfiend EvilDragonfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not change the basic clown equipment by trait directly.
Make a subtype of it where it uses bridge card as its equipment
like this - /datum/outfit/job/clown/station_trait
the new outfit name should be name = "Clown (Bridge Trait)"
my preference is

/datum/outfit/job/clown/station_trait/New()
    name = "[name] (Bridge Trait)"

because Clown job name is sometimes not constant, and New() will change it consistently.

do outfit = /datum/outfit/job/clown/station_trait in /datum/job/clown/New() with if case of station trait

Copy link
Member

@EvilDragonfiend EvilDragonfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine. I will not merge it alone since it has a bit critical aspect.

@Absolucy Absolucy closed this Oct 22, 2023
@Absolucy Absolucy deleted the clown-bridge branch October 22, 2023 19:48
@Absolucy Absolucy restored the clown-bridge branch December 9, 2023 00:23
@Absolucy Absolucy reopened this Dec 9, 2023
@Absolucy
Copy link
Contributor Author

Absolucy commented Dec 9, 2023

forgot to reopen this after i stopped being sad

@Absolucy Absolucy closed this Dec 25, 2023
@Absolucy Absolucy deleted the clown-bridge branch December 25, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants