Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Megafauna no longer gib bodies #9807

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Conversation

mystery3525
Copy link
Contributor

About The Pull Request

Removes the gibbing code from all of the megafauna, meaning they just kill you now and leave your body intact.

Why It's Good For The Game

We're moving away from lavaland being a singleplayer DOOM game, so if it was actually possible to retrieve dead miners then more people will do it and make lavaland more accessible. I feel this is fair as if a death was recent(ish) the megafauna will still be around the body, still posing a challenge to the lavaland paramedics (lol).

Testing Photographs and Procedure

Screenshots&Videos

image

Changelog

🆑
balance: Megafauna no longer gib their victims, meaning you can now retrieve the bodies of miners who were brutally murdered (if you're able to get them out from under the megafauna that is...)
/:cl:

@PowerfulBacon PowerfulBacon added the Balance Approved The balance of this PR has been approved label Sep 8, 2023
Comment on lines 118 to 131
/mob/living/simple_animal/hostile/megafauna/proc/devour(mob/living/L)
if(!L)
return FALSE
visible_message(
"<span class='danger'>[src] devours [L]!</span>",
"<span class='userdanger'>You feast on [L], restoring your health!</span>")
if(!is_station_level(z) || client) //NPC monsters won't heal while on station
adjustBruteLoss(-L.maxHealth/2)
for(var/obj/item/W in L)
if(!L.dropItemToGround(W))
qdel(W)
L.gib()
return TRUE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this proc should go away entirely - megafauna should still have some means of healing after scoring a kill, though I'm not sure by exactly what means.

Do you have any thoughts on it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that with enough dedication and perseverance dying/being recovered/being revived you probably deserve the kill. I don't think there will be any non-snowflake way of making them heal after each kill, and just the time investment in beginning the fight, dying, waiting to be recovered, the paramedic dodging the megafauna, and being brought back to the station (?) and being revived, not by defib mind you because the organs are probably going to be rotten, that you won't get far just trying to brute force bubblegum or something.

@Rukofamicom
Copy link
Contributor

I already made it so miners were always possible to recover in a previous PR, but I suppose it wasn't enough. This is the next logical step to take with regards to trying to make it so miners are more likely to be recovered when killed.

Making it so suit sensors from lavaland are relayed to the station might be worth looking into as well, whether as a part of this PR or a separate one.

@Mails-z
Copy link

Mails-z commented Sep 10, 2023

I remember dying to megafauna, my head was recoverable but most of my items including a GPS (that is meant to be use for your body been track if you die) been destroyed, so yea this would be good.

@Rukofamicom
Copy link
Contributor

Rukofamicom commented Sep 10, 2023

My PR made all items be dropped before gibbing.

It's only a few months old at this point iirc

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Rukofamicom
Copy link
Contributor

Tag is temporary and for secret reasons.

@Rukofamicom Rukofamicom added this pull request to the merge queue Nov 6, 2023
Merged via the queue into BeeStation:master with commit 2bb4dd2 Nov 6, 2023
@mystery3525 mystery3525 deleted the megafauna branch November 9, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved The balance of this PR has been approved Balance/Rebalance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants