Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Z-Clear not properly removing baseturfs #9826

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

itsmeow
Copy link
Member

@itsmeow itsmeow commented Sep 12, 2023

About The Pull Request

Actually includes the baseturf list in the runtime. Why the fuck didn't it do this. Dammit TG.

Pictured useless turfs:
image

With this I was able to find that Z-Clear was not removing baseturfs leading to huge baseturfs lists. I added an argument that should reset the baseturfs.

Why It's Good For The Game

I can actually debug the shit instead of just getting a useless message and then removing the offending turf so I can't even investigate via varedit.

Fixes a bug with baseturfs being huge.

Testing Photographs and Procedure

N/A

Changelog

🆑
tweak: Fixed SHIT IS FUCK turfs in explo generation, improved debugging message so the root cause can be identified.
fix: Fixed large baseturf lists from Z-Clear not clearing baseturfs.
/:cl:

@itsmeow itsmeow added the Test Merged This PR is currently in rotation label Sep 12, 2023
@itsmeow itsmeow changed the title Improve baseturf debugging Fix Z-Clear not properly removing baseturfs Sep 15, 2023
@itsmeow
Copy link
Member Author

itsmeow commented Sep 18, 2023

Nothing on sage since TM
image

@itsmeow itsmeow added Testmerge Passed Seemed fine in testmerge and removed Test Merged This PR is currently in rotation labels Sep 18, 2023
Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good, we don't need to worry about shuttle baseturfs since z-clear will delete the shuttle ports (and also won't run on levels with shuttles on them)

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Sep 18, 2023
Merged via the queue into BeeStation:master with commit 5b008e1 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Testmerge Passed Seemed fine in testmerge Tweak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants