Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TGUI Crew Manifest: Shion Edition #9836

Merged
merged 16 commits into from
Sep 22, 2023
Merged

TGUI Crew Manifest: Shion Edition #9836

merged 16 commits into from
Sep 22, 2023

Conversation

Absolucy
Copy link
Contributor

@Absolucy Absolucy commented Sep 16, 2023 •
edited
Loading

About The Pull Request

Updated version of #8612, with the reviews addressed, and the TGUI interface converted to TypeScript.

Ports

Why It's Good For The Game

Looks better!

Testing Photographs and Procedure

Screenshots&Videos

23-09-17-1694926592 23-09-17-1694926595

Changelog

🆑 Absolucy, RKz, celotajstg, Mothblocks
add: Ports the crew manifest to TGUI.
/:cl:

@Absolucy Absolucy requested a review from itsmeow as a code owner September 16, 2023 01:41
@github-actions github-actions bot added the TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 label Sep 16, 2023
@itsmeow
Copy link
Member

itsmeow commented Sep 16, 2023

What is the function of (x positions open)? did the old one have that? It seems kinda useless tbh since its not per job? at least put (x/x positions) maybe?

@EvilDragonfiend
Copy link
Member

Supply being Cargo is the part of my fault when I did refactor the system, and I was half confused at the moment lol
Cargo is fine to be Supply. Maints and people didn't care that much since both of them are the same in nature.

EvilDragonfiend
EvilDragonfiend requested changes Sep 16, 2023
View reviewed changes
code/__HELPERS/jobs.dm Show resolved Hide resolved
tgui/packages/tgui/interfaces/CrewManifest.tsx Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/CrewManifest.tsx Outdated Show resolved Hide resolved
code/modules/mob/dead/crew_manifest.dm Outdated Show resolved Hide resolved
code/modules/mob/dead/crew_manifest.dm Outdated Show resolved Hide resolved
code/datums/datacore.dm Outdated Show resolved Hide resolved
code/datums/datacore.dm Outdated Show resolved Hide resolved
EvilDragonfiend
EvilDragonfiend requested changes Sep 16, 2023
View reviewed changes
code/datums/datacore.dm Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/CrewManifest.tsx Show resolved Hide resolved
tgui/packages/tgui/interfaces/CrewManifest.tsx Outdated Show resolved Hide resolved
@PowerfulBacon
Copy link
Member

This should have the generic/ooc theming

@EvilDragonfiend
Copy link
Member

EvilDragonfiend commented Sep 16, 2023 •
edited
Loading

This should have the generic/ooc theming

It's also used by silicons, so maybe not.
or it should have a theme value by how it was called.

@EvilDragonfiend
Copy link
Member

I am busy for now. I will revisit next week

itsmeow
itsmeow requested changes Sep 17, 2023
View reviewed changes
code/modules/mob/dead/crew_manifest.dm Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/CrewManifest.tsx Outdated Show resolved Hide resolved
@itsmeow
Copy link
Member

itsmeow commented Sep 18, 2023 •
edited
Loading

Wait, can you add candystripe and show how it looks

@Absolucy
Copy link
Contributor Author

@itsmeow
image

I don't think it looks too good due to Table shenanigans?

@itsmeow
Copy link
Member

itsmeow commented Sep 18, 2023

Looks fine you just need to adjust the vertical centering. Have a look at the load outs page in prefs

@Absolucy
Copy link
Contributor Author

@itsmeow
image

@itsmeow
Copy link
Member

itsmeow commented Sep 18, 2023

Looks great, more readable

EvilDragonfiend
EvilDragonfiend requested changes Sep 21, 2023
View reviewed changes
tgui/packages/tgui/interfaces/CrewManifest.tsx Outdated Show resolved Hide resolved
code/datums/datacore.dm Outdated Show resolved Hide resolved
code/__HELPERS/_lists.dm Show resolved Hide resolved
code/modules/mob/dead/crew_manifest.dm Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/CrewManifest.tsx Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/CrewManifest.tsx Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/CrewManifest.tsx Outdated Show resolved Hide resolved
EvilDragonfiend
EvilDragonfiend approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@EvilDragonfiend EvilDragonfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all look good now

@EvilDragonfiend EvilDragonfiend added this pull request to the merge queue Sep 22, 2023
Merged via the queue into BeeStation:master with commit dfd2910 Sep 22, 2023
ss13-beebot added a commit that referenced this pull request Sep 22, 2023
@ss13-beebot
Automatic changelog generation for PR #9836 [ci skip]
447f83a
@Absolucy Absolucy deleted the crew-manifest-tgui branch September 22, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tsar-Salat Tsar-Salat Tsar-Salat left review comments

@EvilDragonfiend EvilDragonfiend EvilDragonfiend approved these changes

@PowerfulBacon PowerfulBacon PowerfulBacon approved these changes

@itsmeow itsmeow itsmeow approved these changes

Assignees
No one assigned
Labels
Feature TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Absolucy @itsmeow @EvilDragonfiend @PowerfulBacon @Tsar-Salat