Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced wirebrush fix and small tweak #9872

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

CydiaLamiales
Copy link
Contributor

About The Pull Request

Fixes the advanced wirebrush irradiating the user when clicked on anything instead of only after scraping off rust, removes the "Sucessfully scraped off the rust!" popup from the advanced wirebrush.

Why It's Good For The Game

It's kind of stupid how the wirebrush can irradiate you by just clicking on the floor instead of only actually using it. Also because it instantly scrapes off the rust, the "start" and "finish" popup messages for scraping overlap, which looks ugly. So the "finish" message was removed from the advanced wirebrush.

Testing Photographs and Procedure

Screenshots&Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
tweak: removed the "Sucessfully scraped off the rust!" message from the advanced wirebrush to prevent text overlap
fix: fixed the advanced wirebrush irradiating the user on any click instead of only after scraping
/:cl:

@Rukofamicom
Copy link
Contributor

I'm confused by the fact scrubbing rust irradiates people.

Copy link
Contributor

@Rukofamicom Rukofamicom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But confusion about apparently intended mechanics aside, this is a good fix for something clearly already intended.

@Rukofamicom Rukofamicom added this pull request to the merge queue Sep 23, 2023
Merged via the queue into BeeStation:master with commit c8f9b90 Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: give your self RADIATION DAMAGE for FREE!!!!
2 participants