Logging for Inserting & Removing Things Surgically #9873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds logging for inserting new organs via Organ Manipulation. Adds logging for extracting implants from people. Adds logging for storing or removing items surgically using a cavity implant.
EvilDragonfiend
requested changes
Sep 21, 2023
Adds an additional log for when someone attempts to implant/remove organs, implant/remove cavity items, and remove/check for implants. Removed user intent for surgical steps, as they can only be done on help, or disarm (Intentional Failure) which causes a combat log anyway.
|
next time, when you post a PR that you want to close an issue with, you should match a format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds logging for additional surgical processes, as currently with the three operations affected in this PR, it logs when each is started and when an organ is removed via Organ Manipulation. This makes it so organ manipulation logs when organs are inserted as well, cavity implant logs when items are put into or taken out of a body cavity surgically, and when implants are surgically removed from someone or they are checked for implants.
Adds logging for when any of the above procedures are attempted as well, encase the surgeon is interrupted mid procedure.
Why It's Good For The Game
Requested by a Maintainer, seconded by a Seniormin, more logging is good.
Closes issue #9843
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑 Impish_Delights
admin: additional logging for organ manipulation, cavity implant, and implant removal surgeries
/:cl: