Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organ manipulation surgery doesnt feed the patient their organs anymore #9875

Closed
wants to merge 1 commit into from

Conversation

Tsar-Salat
Copy link
Contributor

@Tsar-Salat Tsar-Salat commented Sep 21, 2023

About The Pull Request

closes #8845

Title. Im doing newfood so I might as well fix this stupid thing

Why It's Good For The Game

Stupid edible component

Testing Photographs and Procedure

Screenshots&Videos

I took out their heart, I dont know why it layered below them

dreamseeker_KlyW3DsMaO.mp4

Changelog

🆑 rkz
fix: inserting an organ during organ manipulation surgery doesnt start a progressbar to feed them it
/:cl:

@Rukofamicom
Copy link
Contributor

This raises an extremely minor concern about people starting a self surgery or some such to prevent force feeding, but that's such a niche powergamer move that I'm willing to gamble it won't ever be an actual issue.

@Tsar-Salat
Copy link
Contributor Author

Tsar-Salat commented Sep 22, 2023

This raises an extremely minor concern about people starting a self surgery or some such to prevent force feeding

Yeah, but would you leave your chest wide open? The clown could just waltz on by and steal a kidney when you arent looking!

Comment on lines +322 to +323
if(eater.surgeries.len)
return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People always forget to close their surgeries. This should also require them to be lying down and those surgeries to be mouth surgeries.
Also, organs themselves have the behaviour to prevent surgery feeding specifically on them. That should be fixed instead, or removed if the behaviour is now global.

Copy link
Contributor Author

@Tsar-Salat Tsar-Salat Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People always forget to close their surgeries. This should also require them to be lying down and those surgeries to be mouth surgeries.

Fair enough.

Also, organs themselves have the behaviour to prevent surgery feeding specifically on them.

No. IIRC they have behavior that handles them not accidentally getting a bite taken out of them during surgery. That works fine.

All this PR does is prevent the progress bar from starting due to the edible component. There is no actual problem of organs being eaten, that was fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should never get to this point for organs in the first place. pre_eat is called inside of CanConsume which runs before this part of the proc. If something is an organ, then it won't be able to be consumed if there is a valid surgery in the location that you are trying to feed.

image

image

@PowerfulBacon
Copy link
Member

This PR is redundant due to there already being far more modular code that handles this behaviour specifically for organs only. This would break eating for anyone with active surgeries regardless of context such as the food type being inserted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organ manipulation surgery attempts to feed the inserted organ to the patient
3 participants