Teleporter machinery now autolinks. Adds unit test. #9881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmeow
reviewed
Sep 25, 2023
| // Put down the teleporter machinery | ||
| var/obj/machinery/teleport/hub/hub = allocate(/obj/machinery/teleport/hub) | ||
| var/obj/machinery/teleport/station/station = allocate(/obj/machinery/teleport/station, locate(run_loc_floor_bottom_left.x + 1, run_loc_floor_bottom_left.y, run_loc_floor_bottom_left.z)) | ||
| var/obj/machinery/computer/teleporter/computer = allocate(/obj/machinery/computer/teleporter, locate(run_loc_floor_bottom_left.x + 2, run_loc_floor_bottom_left.y, run_loc_floor_bottom_left.z)) |
There was a problem hiding this comment.
this unit test does not account for placement order
There was a problem hiding this comment.
Maybe? If you place them in different orders a regression might cause one to fail. It's just a coverage thing. I suppose it's fine as is.
itsmeow
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports:
About The Pull Request
Teleporter machinery now autolinks to eachother, no more screwdriver and wirecutters needed.
Adds unit test.
Why It's Good For The Game
This has annoyed the hell out of mentors for eternity. No more.
Testing Photographs and Procedure
Screenshots&Videos
dreamseeker_HTyLzFdt4m.mp4
Changelog
🆑 RKz, Mothblocks
tweak: teleporter machinery now autolinks.
code: adds unit test to ensure this does not regress
/:cl: