Fixes dead people spamming "drowning" messages #9888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvilDragonfiend
previously requested changes
Sep 25, 2023
itsmeow
previously requested changes
Sep 25, 2023
| @@ -125,6 +125,8 @@ | |||
| /datum/component/swimming/proc/drown(mob/living/victim) | |||
| if(victim.losebreath < 1) | |||
| victim.losebreath += 1 | |||
| if(victim.stat > CONSCIOUS) | |||
There was a problem hiding this comment.
This needs to be >= if you want unconcious or dead people to not emote. Also this removes the victim being made unconcious while unconcious when drowning which makes drowning trivial to escape.
There was a problem hiding this comment.
Tried a different approach, could you take a look?
PowerfulBacon
approved these changes
Oct 2, 2023
PowerfulBacon
dismissed stale reviews from itsmeow and EvilDragonfiend
Stale review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Why It's Good For The Game
Doesn't make sense that the body keeps "fainting" after dying.
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑
fix: Fixed dead bodies continuing to make the "drowning" message
/:cl: