Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded beepsky wizard discrimination #9890

Closed
wants to merge 1 commit into from

Conversation

Absolucy
Copy link
Contributor

About The Pull Request

This makes it so wizard+witch clothes don't piss off beepsky

Why It's Good For The Game

Kinda dumb being beepskied over fashion choice

Testing Photographs and Procedure

Screenshots&Videos

Can't really show this easily, as my experience on the server is that beepsky targeting you over this is... very inconsistent

Changelog

🆑
del: Wizard/witch clothes no longer piss off beepsky 4noraisin.
/:cl:

@VickiMorris
Copy link
Contributor

Is Beepsky still racist? Where non-humans have an automatic +1 to their threat?

@Absolucy
Copy link
Contributor Author

Absolucy commented Sep 24, 2023

@VickiMorris yep :(

@hotimep
Copy link

hotimep commented Sep 24, 2023

Is Beepsky still racist? Where non-humans have an automatic +1 to their threat?

feature keep it in

Copy link
Member

@EvilDragonfiend EvilDragonfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either removal of this or making it standard code works to me, and this is fine.

@PowerfulBacon
Copy link
Member

I don't see why these shouldn't set beepsky off

@tontyGH
Copy link
Contributor

tontyGH commented Sep 26, 2023

wizard buff????

Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give a convincing reason as to why this is good for the game

@Absolucy
Copy link
Contributor Author

@PowerfulBacon because it's just... not very fun when beepsky decides to fuck you up because you decided to wear a witch hat from the autodrobe?

@PowerfulBacon
Copy link
Member

I mean, in the eyes of beepskys and turrets, if you look like a threat then the machines will treat you like a threat. I would argue that more things like replica space-suits should cause false positives on machines like beepskys so that they can be wrong

@PowerfulBacon
Copy link
Member

The reason this may feel inconsistent is because of the way that threat takes into account small variables that stack up. Simply wearing wizard clothes isn't enough to get you arrested as it needs at least 4 to mark you as being a beepsky target. If you wear wizard clothes and are marked as incarcarated then it will attack you. If you wear wizard clothes, are a felinid and are marked as search then it will attack you.
Removing this check doesn't make much sense, its part of the clothes and part of the gimmicky nature of both the toy clothes and beepsky (to emulate the real thing).

@PowerfulBacon PowerfulBacon added the 🔑 Close Key (1/3) Indicates that someone has requested this PR to be keyed label Sep 29, 2023
@Absolucy Absolucy closed this Oct 3, 2023
@Absolucy Absolucy deleted the beepsky-bs branch October 3, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔑 Close Key (1/3) Indicates that someone has requested this PR to be keyed Removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants