Remove the virologist (I accidentally nuked the last one) #9901

Haliris · 2023-09-25T16:45:40Z

About The Pull Request

Reopening of #9817

Removes the virologist job. This is the exact same PR as the one that was closed and that we can't reopen.

All change requests made by maintainers have been made before this incident happened.

Why It's Good For The Game

See previous PR.

Testing Photographs and Procedure

Screenshots&Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
del: Removed the virologist job and all of its references in the code and its associated spawners on the maps.
config: Removed the virologist mention in the config.
/:cl:

Removes the virologist job role and all references of it.

Gives noinfections to doctors Reverts removal of virologist vox sound Reverts change to pdas_t_tabs script Removed viro_hud icon

github-actions · 2023-09-25T16:45:55Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

…virologist

Haliris · 2023-09-25T17:03:38Z

Relevant PR regarding removed role playtime hours: #9893

code/modules/cargo/packs.dm

code/modules/mob/living/simple_animal/friendly/hamster.dm

itsmeow · 2023-09-26T15:49:45Z

code/modules/reagents/reagent_containers/bottle.dm

@@ -382,7 +382,7 @@
 /obj/item/reagent_containers/glass/bottle/necropolis_seed
 	name = "bowl of blood"
 	label_name = "blood"
-	desc = "A clay bowl containing a fledgling Necropolis, preserved in blood. A robust virologist may be able to unlock its full potential..."
+	desc = "A clay bowl containing a fledgling Necropolis, preserved in blood. A robust member of medical staff may be able to unlock its full potential..."


Even if the job doesn't technically exist, the role does and there is simply no better way to describe it.

Suggested change

desc = "A clay bowl containing a fledgling Necropolis, preserved in blood. A robust member of medical staff may be able to unlock its full potential..."

desc = "A clay bowl containing a fledgling Necropolis, preserved in blood. A robust virologist may be able to unlock its full potential..."

I'm thinking of future players that may not know that virologist used to be a proper job, and wonder who the "virologist" is when coming to the station with that loot. In my opinion, it's best to just vaguely point them in the direction of medbay with that item.

strings/owo_talk.json

strings/phobia.json

PowerfulBacon · 2023-09-30T19:13:55Z

The virologist workplace needs to be removed somehow, we will either need to expand maints into the areas or create some extra place to put in a few medbays. The corg removal will be easy since it is still the satellite, but the other ones will be a bit harder.

itsmeow · 2023-10-02T14:03:44Z

The virologist workplace needs to be removed somehow, we will either need to expand maints into the areas or create some extra place to put in a few medbays. The corg removal will be easy since it is still the satellite, but the other ones will be a bit harder.

We still need to keep basic virology areas, (Pandemics, extractor, other virology supplies, maybe a monkey or two). We are not removing virology as a mechanic.

PowerfulBacon · 2023-10-02T21:22:45Z

We are removing the virology lab from medical and the virus creation mechanics from roundstart medical. The machines will be buildable, but the machines to produce viruses are being removed from roundstart medbay spawn as was decided would be the best course of action in a prior admin meeting.

The main reasoning, that I agree with, was that with the virology areas still in then medical just becomes more like the scientist job where some peopel can just do something else and ignore the rest of the department for the entire round and we really don't want another science department. I have heard zams had ideas for more ghetto virus creation techniques for antagonists/bored assistants, but I'm not sure how that is going or what is planned for that.

Since most virus curing mechanics are based in chemistry anyway, we don't lose a whole lot when it comes to the ability to cure viruses, however there will need to be a pandemic somewhere in medical so they can produce vaccines for cured viruses. Probably would make the most sense to put it in chemistry.

zeskorion · 2023-10-08T18:09:48Z

We are removing the virology lab from medical and the virus creation mechanics from roundstart medical. The machines will be buildable, but the machines to produce viruses are being removed from roundstart medbay spawn as was decided would be the best course of action in a prior admin meeting.

The main reasoning, that I agree with, was that with the virology areas still in then medical just becomes more like the scientist job where some peopel can just do something else and ignore the rest of the department for the entire round and we really don't want another science department. I have heard zams had ideas for more ghetto virus creation techniques for antagonists/bored assistants, but I'm not sure how that is going or what is planned for that.

Since most virus curing mechanics are based in chemistry anyway, we don't lose a whole lot when it comes to the ability to cure viruses, however there will need to be a pandemic somewhere in medical so they can produce vaccines for cured viruses. Probably would make the most sense to put it in chemistry.

I still have to get to coding it, been sick this week

github-actions · 2023-10-09T09:29:33Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Penwin0 · 2023-10-20T21:49:12Z

DNM lifted, as #9893 dependency is merged

hotimep · 2023-10-21T08:17:46Z

zesko just fell to their knees in a walmart

zeskorion · 2023-10-23T07:33:46Z

zesko just fell to their knees in a walmart

i support the removal of virology and intend to contribute to it when i have the time

Haliris · 2023-10-23T13:19:42Z

I'm busy on another project atm, I'll make the mapping edits next week at best

itsmeow · 2023-10-31T14:31:40Z

Deconflict and uncomment the changes in #9893 for playtime support and we're GTG.

Haliris · 2023-11-09T00:39:29Z

This removal is being folded into: #10153

Will close this once that rework is completed.

zeskorion · 2023-11-09T02:31:44Z

This removal is being folded into: #10153

Will close this once that rework is completed.

👍
working on it now. been doing it during slow hours at work, mostly done. Hard part is gonna be making the department disabled with viro in config, but i think i have an idea

Rukofamicom · 2024-02-17T02:09:18Z

This removal is being folded into: #10153

Will close this once that rework is completed.

I don't see why this should remain open in the meantime, since the other is more or less done at this point.

Haliris added 5 commits September 10, 2023 20:35

Removes virologist job.

977939d

Removes the virologist job role and all references of it.

Removes leftover noinfections code from medical objectives.

7eca5d3

Fixes typo

0cb0a36

Adressed itsmeowdev requests

a24dd7c

Gives noinfections to doctors Reverts removal of virologist vox sound Reverts change to pdas_t_tabs script Removed viro_hud icon

Updated bottle.dm text

9c4b82c

Haliris requested review from itsmeow, PestoVerde322 and Crossedfall as code owners September 25, 2023 16:45

solid-octo-guacamole bot added Code Improvement Config Update Removal labels Sep 25, 2023

github-actions bot added the Merge Conflict label Sep 25, 2023

github-actions bot added Mapping DMM Change Sprites TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 labels Sep 25, 2023

Merge remote-tracking branch 'Haliris/Remove-virologist' into Remove-…

a548029

…virologist

github-actions bot removed the Merge Conflict label Sep 25, 2023

a

922f6ec

Penwin0 added the DO NOT MERGE label Sep 25, 2023

EvilDragonfiend added the Needs Wiki Changes label Sep 25, 2023

itsmeow requested changes Sep 26, 2023

View reviewed changes

"viro" strings removed, fixed typo in cargo\packs

72ff105

github-actions bot added the Merge Conflict label Oct 9, 2023

Penwin0 removed the DO NOT MERGE label Oct 20, 2023

Rukofamicom closed this Feb 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove the virologist (I accidentally nuked the last one) #9901

Remove the virologist (I accidentally nuked the last one) #9901

Haliris commented Sep 25, 2023

github-actions bot commented Sep 25, 2023

Haliris commented Sep 25, 2023

itsmeow Sep 26, 2023

Haliris Sep 27, 2023

PowerfulBacon commented Sep 30, 2023

itsmeow commented Oct 2, 2023

PowerfulBacon commented Oct 2, 2023 •

edited

Loading

zeskorion commented Oct 8, 2023

github-actions bot commented Oct 9, 2023

Penwin0 commented Oct 20, 2023

hotimep commented Oct 21, 2023

zeskorion commented Oct 23, 2023 •

edited

Loading

Haliris commented Oct 23, 2023

itsmeow commented Oct 31, 2023

Haliris commented Nov 9, 2023 •

edited

Loading

zeskorion commented Nov 9, 2023

Rukofamicom commented Feb 17, 2024

	desc = "A clay bowl containing a fledgling Necropolis, preserved in blood. A robust member of medical staff may be able to unlock its full potential..."
	desc = "A clay bowl containing a fledgling Necropolis, preserved in blood. A robust virologist may be able to unlock its full potential..."

Remove the virologist (I accidentally nuked the last one) #9901

Remove the virologist (I accidentally nuked the last one) #9901

Conversation

Haliris commented Sep 25, 2023

About The Pull Request

Why It's Good For The Game

Testing Photographs and Procedure

Changelog

github-actions bot commented Sep 25, 2023

Haliris commented Sep 25, 2023

itsmeow Sep 26, 2023

Choose a reason for hiding this comment

Haliris Sep 27, 2023

Choose a reason for hiding this comment

PowerfulBacon commented Sep 30, 2023

itsmeow commented Oct 2, 2023

PowerfulBacon commented Oct 2, 2023 • edited Loading

zeskorion commented Oct 8, 2023

github-actions bot commented Oct 9, 2023

Penwin0 commented Oct 20, 2023

hotimep commented Oct 21, 2023

zeskorion commented Oct 23, 2023 • edited Loading

Haliris commented Oct 23, 2023

itsmeow commented Oct 31, 2023

Haliris commented Nov 9, 2023 • edited Loading

zeskorion commented Nov 9, 2023

Rukofamicom commented Feb 17, 2024

PowerfulBacon commented Oct 2, 2023 •

edited

Loading

zeskorion commented Oct 23, 2023 •

edited

Loading

Haliris commented Nov 9, 2023 •

edited

Loading