-
-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple knife repath, removes a layer of unecessary nesting #9949
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the UpdatePaths/scripts to include the repathed items so that in the case of merge conflicts, we can just run the script and resolve them
@@ -0,0 +1,2 @@ | |||
/obj/item/knife/ : /obj/item/kitchen/knife/{@OLD} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have the / at the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Those are every knife besides kitchen knives.
/obj/item/kitchen/knife is a kitchen knife. Before it was the parent of all knives, but now it is a derivative of /obj/item/knife. This differentiation is important so regular kitchen knives are converted
In the unlikely event a merge conflict occurs, I will fix it within the hour.
Ports:
About The Pull Request
Repaths all knives from
obj/item/kitchen/knife
toobj/item/knife
, genericized knife behavior is now stored on the parent knife, which shouldnt be spawned in and only be used in checks. Children knives are written likeobj/item/knife/rainbow
orobj/item/knife/combat
There should be no ingame changes, other than I replaced a single Soviet kit to use a combat knife instead of a kitchen knife.
Why It's Good For The Game
Kitchen knives were the first implemented knives in the game many years ago, and so thus all knives derive from it and use its path as a parent. This works fine, but it can be somewhat confusing in coding or trying to debug why heretic blades or rainbow knives are considered a 'kitchen' tool.
Testing Photographs and Procedure
Screenshots&Videos
All typical knife behavior
dreamseeker_81dZQEhkFp.mp4
Changelog
🆑 rkz, itseasytosee
code: repathed knives, removing unecessary nesting
/:cl: