Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upstream] Update to Python 3.11.2, Node 18.14.2, Inferno 8, Typescript 4.9, Yarn 3.4 #2544

Merged
merged 8 commits into from
Nov 10, 2023

Conversation

Bobbanz1
Copy link
Contributor

@Bobbanz1 Bobbanz1 commented Sep 23, 2023

IMPORTANT: READ THIS

This PR breaks TGUI dev for Windows 7 users, but it shouldn't affect the end user.

Carry on

About The Pull Request

Making this a draft as it was a branch created from the same branch as: (No longer relevant as that PR was merged)

Still relevant stuff

This is to...well keep merge conflicts from happening or something.
Anyways what this PR does is the following:

What THAT PR does is the following

  • Updates Python to 3.11.2
  • Node to 18.14.2
  • Bumps python dependencies
  • Removes extra checks run trigger from master branch, since it already runs on merge queue (Not ported as I don't actually know what that stuff does and this seemed to do something to code introduced in another PR on Beestation)
  • Bumps all TGUI dependencies except fantasticon for tgfont, which does not seem to work on 2.0.0
  • Also does not bump "glob" package, since its API changed and it's not really important to be up to date, it's used by the dev server once for the vital task of locating byond cache directories. updating it breaks the shit out of it
  • Also replaced eslint-plugin-radar with the newer, updated eslint-plugin-sonarjs
  • Bumps yarn to 3.4 to fix typescript type imports not working with the PnP loader
  • Rewrites some shoddy typescript imports to work with typescript 4.9 and the newest inferno
  • Updates some internal stuff to be compatible with Inferno 8
  • Adds ts-plugin-inferno for better typescript support of inferno
  • Fixes various linting errors in tgui, such as missing semicolons and key={} attributes on iterators.

Why It's Good For The Game

Keeps those dependencies up to date with beestation, needed for future PRs as well.

Testing Photographs and Procedure

Screenshots&Videos
2023-09-23.13-17-29.mp4

Changelog

🆑itsmeow
server: Update to Python 3.11.2, Node 18.14.2, Inferno 8, Typescript 4.9, Yarn 3.4
/:cl:

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Bobbanz1
Copy link
Contributor Author

You better not have broken as a result of that merge now

@Bobbanz1 Bobbanz1 marked this pull request as ready for review October 20, 2023 08:03
Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rip w7

Copy link

github-actions bot commented Nov 3, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Bokkiewokkie
Bokkiewokkie previously approved these changes Nov 3, 2023
@Bokkiewokkie Bokkiewokkie merged commit ae344ff into BeeStation:master Nov 10, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants