Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upstream] Adds a small vignette that pops up when your laws are changed as AI. #2564

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

someone543
Copy link
Contributor

@someone543 someone543 commented Oct 18, 2023

About The Pull Request

Ports BeeStation/BeeStation-Hornet#9939

From the original PR,
Adds a small vignette that appears momentarily on the screen when laws are changed.
The vignette appears and then immediately fades out, similar to other notifier vignettes.

Why It's Good For The Game

Because having the only indicator for a law change being in the chat window can cause it to be easily missed. Especially in NSV, where an AI could be too busy flying the main ship or gunning to notice the message.
idk it looks cool

Testing Photographs and Procedure

Screenshots&Videos

From the original PR

IMG_0168

IMG_0169

Changelog

🆑 Harranhall
add: Added a vignette that appears momentarily when your laws are changed as AI.
imageadd: added the "law_change" fullscreen vignette.
/:cl:

I really should learn how to port things the right way instead of just copy and pasting things line by line
@Karmic-Skink Karmic-Skink added Update PRs that pull updates from upstream Feature labels Oct 18, 2023
@Bokkiewokkie Bokkiewokkie merged commit a8a6c64 into BeeStation:master Nov 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Active Test Merge Feature Sprites Update PRs that pull updates from upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants