Species names are colored when examining / health analyzing #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bokkiewokkie
requested changes
Nov 12, 2023
my brain completely deleted Ethereals from my memory for the duration of adjusting the PR, but yeah makes sense since they do have their own interaction-critical stuff (like crystallizing if they die) |
Bokkiewokkie
previously approved these changes
Nov 17, 2023
covertcorvid
previously approved these changes
Nov 19, 2023
nsv13/code/modules/mob/living/carbon/human/nsv_human_helpers.dm
Outdated
Show resolved
Hide resolved
DeltaFire15
dismissed stale reviews from covertcorvid and Bokkiewokkie
via
d89a267
EvilDragonfiend
suggested changes
Nov 27, 2023
Bokkiewokkie
approved these changes
Dec 15, 2023
ss13-beebot
added a commit
that referenced
this pull request
Dec 15, 2023
|
Oh, fuck. I didn't post my change request here....
|
This was on purpose and mentioned in the PR description too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Title.
When examining an individual (assuming species is visible), or using a health analyzer on them, their species will be displayed in a color specific to special interactions the species may have.
Caught cases are robots, toxinlovers (oozelings primarily), ethereals, plasmamen, golems, and neither of the other five. The first case that is valid applies its color.
This is a port of Citadel-Station-13/Citadel-Station-13#14783
Also fixes a random ethereal bug I stumbled upon (as I tend to do) that made starvation not increase brute vulnerability in a specific nutrition window.
Why It's Good For The Game
Very small change with high impact on quick species quirk recognition.
Testing Photographs and Procedure
Updated
Changelog
🆑
qol: Species names are now colored when examining / using health analyzers.
fix: Ethereal starvation no longer has a nutrition window where increased brute vulnerability was not handled.
/:cl: