Fixes runtime error when destroying and building gauss turrets #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR fixes a runtime error I encountered while trying to recreate another bug that was reported a few weeks back.
The runtime error in question was this:
I fixed it by giving the machine board for the gauss turret an empty req_components list.
Side effect of fixing it seemed to make the turret itself now leave behind a wired machine frame alongside the board instead of just the board.
Why It's Good For The Game
Makes it less resource consuming to rebuild a destroyed gauss turret since it now leaves behind the machine frame that had been used to build it.
Makes the construction and destruction of the gauss turret not produce a runtime error.
Testing Photographs and Procedure
Screenshots&Videos
Go hit a gauss turret until it's destroyed.
Changelog
🆑
fix: The destruction of a gauss turret now leaves behind the machine frame that had been used to construct it.
code: Gave the machine board of the gauss turret a req_components list with nothing inside it to prevent a runtime error from occurring.
/:cl: