Fixes the "eternal return jump" bug #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bokkiewokkie
added
Fix
Starsystem
Bokkiewokkie
approved these changes
Mar 9, 2024
ss13-beebot
added a commit
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Title.
I got to stare at the runtimes of it happening, and it appears like it is caused by jumping with a disabled thirring drive (which usually gets caught for normal jumps), causing jump speed to be 0, which causes a divby0 error and thus kills the proc.
This makes jumps default to speed 1 (very slow) if the proc chain gets that far with speed <= 0, as that must be a manually called case (no active pylons on thirring should be caught in several prior locations if not directly called / overridden)
Why It's Good For The Game
Fix man good.
Testing Photographs and Procedure
No.
Changelog
🆑
fix: Being recalled with an inactive thirring drive should no longer trap the ship in the darkness between stars.
/:cl: