Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAA Hardsuit Sprite Update #2667

Merged
merged 7 commits into from
Sep 26, 2024
Merged

Conversation

SerynEngi
Copy link
Contributor

@SerynEngi SerynEngi commented May 27, 2024

About The Pull Request

MAA Hardsuit- now with actual NSV sprite!

Why It's Good For The Game

This removes the temporary sprite for the MAA hardsuit in favor of an actually custom-made one courtesy of BluHNT. Also speeds it up a bit because like the CE hardsuit, its made out of better materials.

Testing Photographs and Procedure

MAA hardsuit preview jpeg

Changelog

🆑 SerynEngi and BluHNT
add: Added new MAA hardsuit sprite
balance: made MAA hardsuit less weapon-resistant in exchange for more speed.
/:cl:

@BlueHNT
Copy link
Contributor

BlueHNT commented May 28, 2024

birdmask

Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and sprites look good, though since this is a hardsuit it has the ability to turn on a helmet light by default. I would like it if you included mob and item sprites for the helmet to visualize having it on or off (e.g. ERT helmet in image)
image

@SerynEngi SerynEngi requested a review from Bokkiewokkie June 3, 2024 16:45
Bokkiewokkie
Bokkiewokkie previously approved these changes Jun 5, 2024
Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lämp

@Chickenfarmer48
Copy link

Turning the light on when facing left shifts the helmet one pixel. Doesn't happen when facing any other direction.
image
image

@Bokkiewokkie Bokkiewokkie dismissed their stale review June 28, 2024 18:51

New issue still present

@SerynEngi SerynEngi closed this Jul 21, 2024
@SerynEngi SerynEngi deleted the MAAhardsuitsprite branch July 21, 2024 05:49
@Bokkiewokkie Bokkiewokkie restored the MAAhardsuitsprite branch September 14, 2024 15:53
@Bokkiewokkie Bokkiewokkie reopened this Sep 14, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

@Bokkiewokkie Bokkiewokkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool PR I definitely didn't work on this myself at the end there haha where did you get that idea

@Bokkiewokkie Bokkiewokkie merged commit 3b04060 into BeeStation:master Sep 26, 2024
8 of 9 checks passed
IndusRobot pushed a commit to IndusRobot/NSV13 that referenced this pull request Dec 16, 2024
Co-authored-by: BlueHNT <[email protected]>
Co-authored-by: Bokkiewokkie <[email protected]>
IndusRobot pushed a commit to IndusRobot/NSV13 that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants