-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Energy weapon gameplay enhancement #2677
base: master
Are you sure you want to change the base?
Changes from 64 commits
f6a1bbc
84f5e84
f195f10
cb4f10d
3ff6f12
13d3284
b810d0b
fee976e
b48910a
0628c34
95cadb1
eeaa255
37c75c6
0e585ba
118c6aa
67c2c21
3a6cb59
5c10d26
d6fda76
123a928
5ff9d82
9ef2982
ff8852a
05c6630
587bba8
8555e0c
16e47ee
4d7ad96
a5020e6
ae3ef3d
2cf2cd5
eb5e1c5
0f84efc
91256ad
ca43fb8
de4e85d
5b1febc
b629386
8ba19dc
20bd0ed
4f6492a
db043f6
9b97e85
feb5d39
506c1f8
a217d41
eb7f898
b5e13c0
cec528d
255781d
6307cc6
0bfeaeb
9f82af6
3f60748
e625c42
329b988
1c2eac4
733e882
20366cf
786a43c
d5bbe5d
1794197
ba1b6ad
a4f1b4a
7bbf638
091defc
2d534b0
ddb1999
7ef0ecd
acbeb40
d211a01
8d3ff18
e815574
490e929
a4bd409
f8b7374
e57ea3f
58bcbf7
4e41766
f6ba70b
b5668ba
2f4706a
9a8dca7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,6 @@ | ||
|
||
// If you continue to complain that munitechs have nothing to do, then I guess you really have nothing to do now don't you? | ||
// I'm replacing your job with bridge officers who are perfectly capable of pushing a button on lasers | ||
// MAP_REMOVE_JOB(master_at_arms) | ||
MAP_REMOVE_JOB(munitions_tech) | ||
|
||
/datum/job/munitions_tech/New() | ||
..() | ||
MAP_JOB_CHECK | ||
total_positions = 0 | ||
spawn_positions = 0 | ||
|
||
/datum/job/master_at_arms/New() | ||
..() | ||
MAP_JOB_CHECK | ||
total_positions = 0 | ||
spawn_positions = 0 | ||
// this file should be obsolete | ||
|
||
#undef JOB_MODIFICATION_MAP_NAME |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -227,3 +227,10 @@ | |
var/mob/living/goodbye = target | ||
goodbye.dust(TRUE, FALSE) | ||
explosion(get_turf(target), 6, 8, 9, 12, ignorecap = TRUE, flame_range = 6) //I have to keep myself from letting it just truncate ships because thats a bit annoying to fix for the receiving side, even if accurate to appearance. | ||
|
||
|
||
/obj/machinery/ship_weapon/energy/beam/bsa/after_fire() //NT gets to cheat and have no degadation or heating on their weapon because muni has enough to do and the BSA doesn't need buffs/nerfs | ||
. = ..() | ||
heat = 0 | ||
alignment = 100 | ||
freq = 100 | ||
Comment on lines
+232
to
+236
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bit hacky. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd have to add a check for that in every part of the system though right? Would that be better There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's the classic "address now vs. address later" issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use this level of "true" sheet use for any machinery. It makes them loot pinatas if mapspawned and also is in itself a bit hillarious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think it makes sense for a heat related machine, and unless you don't want functional weapons, you can't scrap them, then again.
I don't want them to be super cheap though, should I make the boards more expensive in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use custom components which are expensive to print, for example; This makes them somewhat harder to efficiently cannibalize (and adds a layer of ambiguosity), over just ejecting & slamming in a stack of 30 copper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true. Probably a much cleverer idea than just slamming in a minecart's worth of raw metal
It will need sprites tho