adds a warning noise when ships with shields take damage to the hull #2680
Conversation
|
I have nothing to say pertaining to whether or not we use this effect. I've explained before that this variety of shield generator doesn't really have a down state except when it loses power. You already know that the shield is insufficient for the hit when you start taking the hits on the hull, so a "down" state is something I view as unneeded. What I will say is that the effect isn't unused. This sound is straight from the PDSR.
|
I didn't actually check to see if it was used which is my bad, in this case all it does is play this sound when a ship with shields has the shields not stop something, with a fairly long cooldown(for sounds)- this would probably happen with the pdsr as well |
| @@ -43,6 +43,11 @@ Bullet reactions | |||
| return BULLET_ACT_FORCE_PIERCE // :) | |||
| else | |||
| return FALSE //Shields absorbed the hit, so don't relay the projectile | |||
| if(shield_result == SHIELD_NOEFFECT && !failure_sound_cooldown) | |||
There was a problem hiding this comment.
Okay, now I have a comment on the code. If I'm reading this right, it looks like it will play the shields down effect at the same time it would play the projectile hitting sound with a cooldown of 5 seconds.
To make it plain- this is adding a sound just to add a sound. It does not provide any useful information or tell people things they don't already know, and clutters the already loud sounds of combat.
There was a problem hiding this comment.
I personally think it's nice to have the little extra warning- it can be hard to tell sometimes, but I could look into moving the trigger into when the shield's charge is dropped to zero- but that'll play even when you aren't actually taking damage
There was a problem hiding this comment.
I have nearly 300hrs in engineering and probably a solid 20hrs of that standing at that shield generator. It is never at zero for more than a moment unless the power requested is higher than the power provided.
It is also extremely obvious to everyone when the shield are down because the shield deflect sounds stop playing and the hull hit effects start.
If you want to add in a warning effect for when the shields are at 33% of effective strength or less with an appropriate cooldown, that would be useful- and would not be attached to actual projectile hits. It would belong in the shield generator dm file and not in damage.dm
There was a problem hiding this comment.
Even more importantly, this sound effect will also trigger with the PDSR, as this is damage.dm and the PDSR uses this sound for another reason. So you're going to have that PDSR sound playing for 2 separate reasons on the Galactica.
There was a problem hiding this comment.
fine whatever. I'll just close this then
About The Pull Request
there was an unused shield failure noise in the game files. it's used now
Testing Photographs and Procedure
Screenshots&Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
add: added a warning sound for hull hits when the shields fail
/:cl: