Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space mines, Syndicate stealth attacks #2693

Merged
merged 16 commits into from
Sep 26, 2024

Conversation

Bokkiewokkie
Copy link
Contributor

About The Pull Request

This PR adds space mines, a new weapon invented by combining Syndicate cloaking technology with high-yield explosives. Currently Aspala-class submarines, Mako flak frigates, and combat carriers will be able to drop them when fleeing or patrolling.

Why It's Good For The Game

More fun stuff to die to, it also makes Syndicate systems more dangerous by spawning a few mines in them at roundstart.

Testing Photographs and Procedure

I tested it. Only shooting doesn't work nicely (you need to actually click on a mine to hit it right now)

Changelog

🆑
add: Added space mines
/:cl:

I also moved all of the torps to the left by one pixel
Watch out when flying into Syndicate space!
@Bokkiewokkie Bokkiewokkie added Feature Overmap This issue or PR is related to overmap interactions Starsystem Issues and pull requests related to star systems. labels Jul 5, 2024
Copy link
Contributor

@DeltaFire15 DeltaFire15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick preliminary review.

nsv13/code/controllers/subsystem/starsystem.dm Outdated Show resolved Hide resolved
nsv13/code/controllers/subsystem/starsystem.dm Outdated Show resolved Hide resolved
nsv13/code/modules/overmap/ai-skynet.dm Outdated Show resolved Hide resolved
nsv13/code/controllers/subsystem/starsystem.dm Outdated Show resolved Hide resolved
nsv13/code/modules/overmap/weapons/mines.dm Outdated Show resolved Hide resolved
nsv13/code/modules/overmap/weapons/mines.dm Outdated Show resolved Hide resolved
nsv13/code/modules/overmap/weapons/mines.dm Outdated Show resolved Hide resolved
nsv13/code/modules/overmap/weapons/mines.dm Outdated Show resolved Hide resolved
nsv13/code/modules/projectiles/projectile.dm Outdated Show resolved Hide resolved
nsv13/code/modules/overmap/ai_interiors.dm Outdated Show resolved Hide resolved
nsv13/code/modules/overmap/weapons/mines.dm Show resolved Hide resolved
nsv13/code/modules/overmap/weapons/mines.dm Outdated Show resolved Hide resolved
Copy link
Contributor

@DeltaFire15 DeltaFire15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

You could probably reset mine count somewhere in try_threat_elevation_reinforce() if you want them to not refill within a fight itself and rearm outside of one, but I don't see any real issues anywhere.

@Bokkiewokkie
Copy link
Contributor Author

Looks good to me.

You could probably reset mine count somewhere in try_threat_elevation_reinforce() if you want them to not refill within a fight itself and rearm outside of one, but I don't see any real issues anywhere.

Figured for now I'd like to keep them somewhat sparse, it adds a bit to the surprise factor

@Bokkiewokkie Bokkiewokkie merged commit a528f3f into BeeStation:master Sep 26, 2024
8 of 9 checks passed
@Bokkiewokkie Bokkiewokkie deleted the Theycallitamine branch September 26, 2024 10:42
IndusRobot pushed a commit to IndusRobot/NSV13 that referenced this pull request Dec 16, 2024
IndusRobot pushed a commit to IndusRobot/NSV13 that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Active Test Merge Feature Overmap This issue or PR is related to overmap interactions Starsystem Issues and pull requests related to star systems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants