[ON-40378] Fix crash in wakelock.c regarding releasing JNI references.

BelledonneCommunications · Jul 28, 2016 · 1c6f084 · 1c6f084
1 parent 6a8f281
commit 1c6f084
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/wakelock.c b/src/wakelock.c
@@ -29,7 +29,6 @@ void belle_sip_wake_lock_init(JNIEnv *env, jobject pm) {
 		jfieldID fieldID;
 
 		(*env)->GetJavaVM(env, &ctx.jvm);
-		ctx.powerManager = (*env)->NewGlobalRef(env, pm);
 		pthread_key_create(&ctx.jniEnvKey, jni_key_cleanup);
 
 		powerManagerClass = (*env)->FindClass(env, "android/os/PowerManager");
@@ -45,10 +44,12 @@ void belle_sip_wake_lock_init(JNIEnv *env, jobject pm) {
 	} else {
 		belle_sip_warning("bellesip_wake_lock_init(): the wakelock system has already been initialized");
 	}
+	if (ctx.powerManager == NULL) {
+		ctx.powerManager = (*env)->NewGlobalRef(env, pm);
+	}
 }
 
 void belle_sip_wake_lock_uninit(JNIEnv *env) {
-	ctx.jvm = NULL;
 	if(ctx.powerManager != NULL) {
 		(*env)->DeleteGlobalRef(env, ctx.powerManager);
 		ctx.powerManager = NULL;
@@ -61,7 +62,7 @@ void belle_sip_wake_lock_uninit(JNIEnv *env) {
  * @param data Unused.
  */
 static void jni_key_cleanup(void *data) {
-	JNIEnv *env = pthread_getspecific(ctx.jniEnvKey);
+	JNIEnv *env = (JNIEnv*) data;
 	belle_sip_message("Thread end. Cleanup wake lock jni environment");
 	if(env != NULL) {
 		if(ctx.jvm != NULL) {