Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: previous/next buttons support #235

Merged
merged 5 commits into from
Apr 30, 2024
Merged

feat: previous/next buttons support #235

merged 5 commits into from
Apr 30, 2024

Conversation

Bellisario
Copy link
Owner

@Bellisario Bellisario commented Apr 29, 2024

Currently the implementation of Musicale only handles "Next" and "Previous" keyboard buttons, which are keyboard-specific and could not be available to everyone, so "Next" and "Previous" buttons on the player are needed.

This pull implements the following:

  • "Next" and "Previous" buttons on the play bar
  • Buttons appear only when needed
  • An option in settings lets user disable these buttons if wanted
  • Buttons appear/disappear (possibly) with an animation
  • Buttons become a bit darker (showing they're disabled) when there's no previous/next song to play
  • Right click on "Play Next" button allows switching to previous/next song

demo

@Bellisario Bellisario linked an issue Apr 29, 2024 that may be closed by this pull request
6 tasks
@Bellisario Bellisario marked this pull request as ready for review April 30, 2024 18:27
@Bellisario Bellisario merged commit 27b5e47 into main Apr 30, 2024
3 checks passed
@Bellisario Bellisario deleted the previous-next-buttons branch April 30, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: "Next" and "Previous" buttons on the player
1 participant