feat(s3): support default credentials provider in AWS S3 storage #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohilsurana
force-pushed
the
aws-credentials
branch
from
5bde306 to
9a0807a
Compare
rohilsurana
commented
Jan 17, 2025
Comment on lines
+52
to
+64
| ticker := time.NewTicker(10 * time.Minute) | ||
| time.Tick(10 * time.Minute) | ||
| go func() { | ||
| for { | ||
| select { | ||
| case <-ticker.C: | ||
| duckdb.setAwsCredentials(ctx) | ||
| case <-duckdb.refreshQuit: | ||
| ticker.Stop() | ||
| return | ||
| } | ||
| } | ||
| }() |
There was a problem hiding this comment.
This refresh logic is required because duckdb doesn't refresh credentials. Ref - duckdb/duckdb-aws#26
TODO: refactor to provide refresh interval as a config.
rohilsurana
force-pushed
the
aws-credentials
branch
from
9a0807a to
e9f3aa3
Compare
arjunlol
force-pushed
the
main
branch
3 times, most recently
from
89db433 to
a45307d
Compare
|
Hey @rohilsurana — thanks a lot for submitting this pull request! 🎉 We've merged it by making some small adjustments to avoid adding an extra configuration option and to keep it as simple as possible from a usability perspective. I.e., if the AWS access key is not specified, it'll fallback to the AWS SDK credential chain trying to get the credentials from the config file, STS, or SSO. This has been released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the only way to set AWS credentials is via setting the static credentials as environment variables or by passing as a flag when executing.
Some systems already have credentials setup using different ways provided by aws like credentials file, config file or EC2 profiles.
Solution
This PR adds support for using AWS S3 credentials from default credentials provider chain in the SDK.
The order for the AWS SDK golang is documented at [1].
The order for duckdb is documented at [2].
Changes
AWS_CREDENTIALS_TYPEwith optionsSTATICandDEFAULT.STATICmaintains the old behaviour and uses the supplied static credentials.DEFAULTuses the AWS SDK and DuckDB default credentials chain.create secretquery changes for creating S3 secret as per new config.[1] AWS SDK Golang - https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/configuring-sdk.html#specifying-credentials
[2] DuckDB S3 API Support - https://duckdb.org/docs/extensions/httpfs/s3api.html#credential_chain-provider