Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tas 151 make auth token editable #30

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Conversation

csrubin
Copy link
Collaborator

@csrubin csrubin commented Feb 27, 2024

Impact

This PR allows for event passwords to be optional and editable. Additionally adds optional email input, and sends event details upon save. Remove token dialog flow.

@csrubin csrubin changed the base branch from main to tas-64-add-alembic-migrations February 27, 2024 19:31
@csrubin csrubin force-pushed the tas-151_make-auth-token-editable branch from a48ff00 to c6d6510 Compare February 27, 2024 19:36
@csrubin csrubin changed the base branch from tas-64-add-alembic-migrations to main February 27, 2024 19:36
Copy link
Owner

@BenMemberg BenMemberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small things 👍

how2meet/routers/events.py Outdated Show resolved Hide resolved
how2meet/ui/components/event_editor.py Outdated Show resolved Hide resolved
how2meet/ui/components/event_editor.py Outdated Show resolved Hide resolved
except smtplib.SMTPException as e:
ui.notify(f"Failed to send email with error: {e}")

ui.open(URL_EVENT_HOME.format(event_id=self.event_id))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the redirect 👍

@csrubin csrubin merged commit 0b4966a into main Feb 29, 2024
1 check passed
@csrubin csrubin deleted the tas-151_make-auth-token-editable branch February 29, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants