Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No tree growth #355

Closed
SlimeDog opened this issue Jul 12, 2020 · 34 comments
Closed

No tree growth #355

SlimeDog opened this issue Jul 12, 2020 · 34 comments
Assignees
@tastybento
Labels
bug Something isn't working under investigation

Comments

@SlimeDog
Copy link

SlimeDog commented Jul 12, 2020 •
edited
Loading

Description

Describe the bug

Newly planted sapling does not grow.

Steps to reproduce the behavior

  • Unregister player from previous island
  • /island
  • Cut tree
  • Plant sapling in original tree location
  • Wait patiently
  • Observe that sapling does not grow
  • Observe that light level = 15 and space is adequate -- same space as original tree
  • Finally, cheat with bonemeal to test growth capability -- it does not

Expected behavior

  • Normal tree growth.

Environment

Output of /bbox version (Mandatory)
>bbox version
[09:41:09] [Server thread/INFO]: Running SPIGOT 1.16.1.
[09:41:09] [Server thread/INFO]: BentoBox version: 1.14.1-SNAPSHOT-b1835
[09:41:09] [Server thread/INFO]: Database: JSON
[09:41:09] [Server thread/INFO]: Loaded Game Worlds:
[09:41:09] [Server thread/INFO]: world_skyblock (SkyBlock): Overworld, [nether_color]Nether, [end_color]End
[09:41:09] [Server thread/INFO]: Loaded Addons:
[09:41:09] [Server thread/INFO]: Biomes 1.13.0-SNAPSHOT-b180 (ENABLED)
[09:41:09] [Server thread/INFO]: BSkyBlock 1.13.0-SNAPSHOT-b601 (ENABLED)
[09:41:09] [Server thread/INFO]: Challenges 0.9.0-SNAPSHOT-b420 (ENABLED)
[09:41:09] [Server thread/INFO]: ExtraMobs 1.11.0.4-SNAPSHOT-b7 (ENABLED)
[09:41:09] [Server thread/INFO]: Level 2.3.2-SNAPSHOT-b396 (ENABLED)

For reference, Spigot Jenkins build 2827.
@SlimeDog
Copy link
Author

SlimeDog commented Jul 12, 2020 •
edited
Loading

From the first new island, I executed /is reset (twice) to generate a completely new island. Tree growth occurred normally.

@tastybento
Copy link
Member

I don't know if you've been updating your server as well, but they are fixing bugs with 1.16.1 so maybe there's some ticking issues. There's nothing we're doing to prevent tree growth so this is not really actionable right now.

@SlimeDog
Copy link
Author

SlimeDog commented Jul 12, 2020 •
edited
Loading

Server is 1.16.1 latest, within 1 hour of each code change. I have a monitor on the Spigot change log.

Obviously, SkyBlock is unusable if one cannot grow a tree.

@SlimeDog
Copy link
Author

This issue is easily reproducible on my up-to-date Spigot 1.16.1. It might be worth a look.

@tastybento
Copy link
Member

You write:

Finally, cheat with bonemeal to test growth capability -- it does not

Does this mean that even with bonemeal you cannot grow the tree?

@tastybento tastybento added the cannot replicate this cannot be replicated on a base installation label Jul 13, 2020
@SlimeDog
Copy link
Author

Does this mean that even with bonemeal you cannot grow the tree?

That is correct. After the lengthy unsuccessful waiting, I decided to test with bonemeal, just to see if the sapling would grow at all. It would not. I have replicated this sequence three times out of three attempts.

@tastybento
Copy link
Member

tastybento commented Jul 13, 2020 •
edited
Loading

I set up two players on the test server, which is running Paper-90 1.16.1. I planted sapling and waited with F3 enabled to track growth. Both grew into saplings after waiting for sufficient time.

I started taking screenshots after seeing the Sapling Stage move from 0 to 1:
Screen Shot 2020-07-12 at 5 52 51 PM
Screen Shot 2020-07-12 at 6 06 39 PM
This tree took about 14 minutes to grow.

Here's a totally new island:
Stage 0
Screen Shot 2020-07-12 at 5 53 05 PM
Stage 1
Screen Shot 2020-07-12 at 5 53 19 PM
Fully grown
Screen Shot 2020-07-12 at 6 06 48 PM

@tastybento
Copy link
Member

I just saw your comment about bonemeal not working. That sounds like something is blocking growth completely.

Can you do /is info for this island?

@tastybento
Copy link
Member

Also try this, set this setting to Active - /bsb settings and try again:

Screen Shot 2020-07-12 at 6 15 42 PM

@SlimeDog
Copy link
Author

SlimeDog commented Jul 13, 2020 •
edited
Loading

I do not see that you followed my script, particularly the /unregister player then /island part. Plausible explanation: After that sequence, BSB believes that the player it outside protection range.

I have already started a new island test, so would prefer not to go back to this. I have replicated it previously.

@tastybento
Copy link
Member

tastybento commented Jul 13, 2020 •
edited
Loading

I did follow your sequence. On the island with the cow pig and duck I unregistered, and did /island.

If you cannot grow a tree using bonemeal on your island then yes, it's likely that the tree growth is being blocked by that setting. If you change that setting to Active and bonemeal allows it then that will confirm it. Then we need to find out why BentoBox thinks you are no longer on your island, so do /is info when on the island and look at what it says compared to your coords.

Remember, if you are Op, you might be placing blocks where normal players are not allowed to place them.

@SlimeDog
Copy link
Author

The player is OP, but I do not see that he is doing anything OP-restricted.

Original island information

>bsbadmin info PLAYER_ELIDED
[18:47:19] [Server thread/INFO]: ========== Island Info ============
[18:47:19] [Server thread/INFO]: UUID: BSkyBlock4ead2e89-b302-40d2-b638-3cce0631f9cb
[18:47:19] [Server thread/INFO]: Owner: PLAYER_ELIDED
[18:47:19] [Server thread/INFO]: Last login: Sun Jul 12 14:00:01 PDT 2020
[18:47:19] [Server thread/INFO]: Deaths: 0
[18:47:19] [Server thread/INFO]: Resets: 0 (Max: 2)
[18:47:19] [Server thread/INFO]: Team members:
[18:47:19] [Server thread/INFO]: PLAYER_ELIDED Owner
[18:47:19] [Server thread/INFO]: Island location: 512,120,512
[18:47:19] [Server thread/INFO]: Island coordinates: 256,0,256 to 767,256,767
[18:47:19] [Server thread/INFO]: Protection range: 128
[18:47:19] [Server thread/INFO]: Largest historical protection range: 128
[18:47:19] [Server thread/INFO]: Protection coordinates: 384,0,384 to 639,256,639

>bsbadmin unregister PLAYER_ELIDED

/island

which creates a new island (which is unlit, per #354.
Dogs arrived, which may be a hint of bad juju, since per #1450 they should not.

>bsbadmin info PLAYER_ELIDED
[18:55:53] [Server thread/INFO]: ========== Island Info ============
[18:55:53] [Server thread/INFO]: UUID: BSkyBlock52b106a0-8da8-4031-9c86-c83019fe57fb
[18:55:53] [Server thread/INFO]: Owner: PLAYER_ELIDED
[18:55:53] [Server thread/INFO]: Last login: Sun Jul 12 14:00:01 PDT 2020
[18:55:53] [Server thread/INFO]: Deaths: 0
[18:55:53] [Server thread/INFO]: Resets: 0 (Max: 2)
[18:55:53] [Server thread/INFO]: Team members:
[18:55:53] [Server thread/INFO]: PLAYER_ELIDED Owner
[18:55:53] [Server thread/INFO]: Island location: 0,120,512
[18:55:53] [Server thread/INFO]: Island coordinates: -256,0,256 to 255,256,767
[18:55:53] [Server thread/INFO]: Protection range: 128
[18:55:53] [Server thread/INFO]: Largest historical protection range: 128
[18:55:53] [Server thread/INFO]: Protection coordinates: -128,0,384 to 127,256,639
  • Cut tree
  • Plant sapling
  • Wait ...
  • Attack sapling with bonemeal, no joy

Trees growing outside range is disabled. I do not want to change it. We run all default settings.

@tastybento
Copy link
Member

What is your BSkyblock island config?

It looks like you have an island distance of 512? Did you change that recently?

If you change the tree growth setting to Active as an experiment, can you grow the tree via bonemeal? At what location is the tree on this island?

If you change the player to not be Op as an experiment can the player place blocks on the island?
If not, run the admin why command and see why he cannot.

Finally, can you zip up the BentoBox folder (and database) and share it so I can try and replicate?

@SlimeDog
Copy link
Author

SlimeDog commented Jul 13, 2020 •
edited
Loading

Download of plugins/BentoBox/addons/BSkyBlock/config.yml
Please advise when you have copied it, so I can delete it.

Island distance = 512 since very early on, certainly not recently. I believe that it was set before any islands were created (and the island info -- see above -- certainly reinforces that), but I cannot guarantee it.

I will try Active and report back. Sapling is at the location of the original tree.

I will try non-OP and report back.

@SlimeDog
Copy link
Author

SlimeDog commented Jul 13, 2020 •
edited
Loading

non-OP test

Made PLAYER_ELIDED non-OP, then

>bsbadmin unregister PLAYER_ELIDED
[08:08:50] [Server thread/INFO]: Type command again within 10s to confirm.
>bsbadmin unregister PLAYER_ELIDED
[08:08:52] [Server thread/INFO]: Unregistered player from island at 512,120,512.

Player executes /island and is transported to an island on which they cannot break blocks

>bsbadmin why
[08:09:46] [Server thread/INFO]: =========== SkyBlock help ===========
[08:09:46] [Server thread/INFO]: /bsbadmin why <player>: toggle console protection debug reporting
[08:09:46] [Server thread/INFO]: =================================
>bsbadmin why PLAYER_ELIDED
[08:09:51] [Server thread/INFO]: Turning on console debug for PLAYER_ELIDED.
[08:10:02] [Server thread/INFO]: [BentoBox] Why: BlockBreakEvent in world world_skyblock at 0,126,512
[08:10:02] [Server thread/INFO]: [BentoBox] Why: PLAYER_ELIDED BREAK_BLOCKS - NOT_ALLOWED_IN_WORLD
>bsbadmin info PLAYER_ELIDED
[08:13:07] [Server thread/INFO]: ========== Island Info ============
[08:13:07] [Server thread/INFO]: UUID: BSkyBlock73b2e11d-7528-4a6f-bca3-a99c48f3a1b6
[08:13:07] [Server thread/INFO]: Owner: PLAYER_ELIDED
[08:13:07] [Server thread/INFO]: Last login: Mon Jul 13 07:47:31 PDT 2020
[08:13:07] [Server thread/INFO]: Deaths: 0
[08:13:07] [Server thread/INFO]: Resets: 0 (Max: 2)
[08:13:07] [Server thread/INFO]: Team members:
[08:13:07] [Server thread/INFO]: PLAYER_ELIDED Owner
[08:13:07] [Server thread/INFO]: Island location: 0,120,512
[08:13:07] [Server thread/INFO]: Island coordinates: -256,0,256 to 255,256,767
[08:13:07] [Server thread/INFO]: Protection range: 128
[08:13:07] [Server thread/INFO]: Largest historical protection range: 128
[08:13:07] [Server thread/INFO]: Protection coordinates: -128,0,384 to 127,256,639

/island reset produces the infamous

[08:14:32] [Server thread/ERROR]: No key position_predicate in MapLike[{location_predicate:{predicate_type:"minecraft:always_true"},output_state:{Name:"minecraft:mossy_cobblestone"},input_predicate:{predicate_type:"minecraft:random_block_match",probability:0.2f,block:"minecraft:cobblestone"}}]

and many, many more similar console/log errors.
But the new island is created, on which the player can break blocks.

>bsbadmin info PLAYER_ELIDED
[08:17:35] [Server thread/INFO]: ========== Island Info ============
[08:17:35] [Server thread/INFO]: UUID: BSkyBlock613acb54-0578-4eb3-b83e-5dcb3cff0699
[08:17:35] [Server thread/INFO]: Owner: PLAYER_ELIDED
[08:17:35] [Server thread/INFO]: Last login: Mon Jul 13 07:47:31 PDT 2020
[08:17:35] [Server thread/INFO]: Deaths: 0
[08:17:35] [Server thread/INFO]: Resets: 1 (Max: 2)
[08:17:35] [Server thread/INFO]: Team members:
[08:17:35] [Server thread/INFO]: PLAYER_ELIDED Owner
[08:17:35] [Server thread/INFO]: Island location: 512,120,0
[08:17:35] [Server thread/INFO]: Island coordinates: 256,0,-256 to 767,256,255
[08:17:35] [Server thread/INFO]: Protection range: 128
[08:17:35] [Server thread/INFO]: Largest historical protection range: 128
[08:17:35] [Server thread/INFO]: Protection coordinates: 384,0,-128 to 639,256,127

@SlimeDog
Copy link
Author

Do you still need the "Active" test, or did the non-OP test provide enough information?

@tastybento
Copy link
Member

This looks suspicious:

[08:10:02] [Server thread/INFO]: [BentoBox] Why: PLAYER_ELIDED BREAK_BLOCKS - NOT_ALLOWED_IN_WORLD

What happened here? Did he try to break a block on the island? Can you do F3 and actually check where the coordinates are? Also, does this player have a range perm on him such that the island range is changing? (I assume not, but just checking).

@SlimeDog
Copy link
Author

SlimeDog commented Jul 14, 2020 •
edited
Loading

I would say more than suspicious -- indicative. It was the result of trying to chop a log out of the tree (as OP, I was able to chop the tree, but not as non-OP). The coordinate was 0,126,512 -- the second block from the bottom of the original tree. The in-game message was World protected: Block breaking disabled.

@tastybento
Copy link
Member

tastybento commented Jul 14, 2020 •
edited
Loading

Why is the player at that location? 0, 126, 512? His island is at 512,120,0... oh wait - I see. Let me study this...

@tastybento
Copy link
Member

Okay, a few questions:

  1. Is this repeatable? It is that every time you unregister, then make an island, you cannot interact with it until you reset?
  2. Is it just this player, or any other?
  3. Can you share your BentoBox folder zipped up so I can try it?

@tastybento tastybento self-assigned this Jul 14, 2020
@SlimeDog
Copy link
Author

Why is the player at that location? 0, 126, 512? His island is at 512,120,0... oh wait - I see. Let me study this...

You're looking at the third island. Look at the second (failing) island.

@SlimeDog
Copy link
Author

Okay, a few questions:

  1. Is this repeatable? It is that every time you unregister, then make an island, you cannot interact with it until you reset?

Correct.

  1. Is it just this player, or any other?

I have two test players.
The first -- PLAYER_ELIDED above -- is usually OP, but was de-OP'd as requested for the later tests. His original island is moderately developed -- level 127. The failure is repeatable.
The second is new for every test (I restart testing on backups of a known configuration). The failure did not occur for the second player, although the No key position_predicate in MapLike error occurred.

  1. Can you share your BentoBox folder zipped up so I can try it?

http://blackdog.straight8.com/drops/BBox.zip
Again, please let me know when you have it, so I can remove it.

@tastybento
Copy link
Member

Downloaded.

@tastybento
Copy link
Member

I managed to replicate this with your database. I haven't worked out why it's happening yet, but I have an island that isn't mine but should be. It survives even after a reboot. Investigating...

@tastybento tastybento added bug Something isn't working and removed cannot replicate this cannot be replicated on a base installation labels Jul 15, 2020
@SlimeDog
Copy link
Author

What a relief. Thanks.

@tastybento
Copy link
Member

I'm a bit brain frazzled right now. I'll need to look at this tomorrow.

@SlimeDog
Copy link
Author

No hurry at this end. I get around it easily. I just thought that you would want to figure it out, it case it goes deeper or wider.

@tastybento
Copy link
Member

I found the offending database entry - it's an island file called 0d6b9b3c-a0a1-49f2-9cd4-a0d3141d3c64.json. This file must be from a long time ago because it's not prefixed with the addon name. This island file has a range of only 128 and not 256. When this file is deleted, things start working again. I think it's messing with the grid manager somehow. Anyway, I suspect it's a left-over from a previous install you did and maybe didn't get deleted? Try and remove it and let me know if it fixes the issue for you.

@SlimeDog
Copy link
Author

Removing that file resolved the issue.

As you know, I have been testing BentoBox/BSkyBlock from the first dev release. The data presentation has changed radically over time. Newer releases do not detect leftover potential problems, so it has proved very difficult to upgrade across releases (it is relatively easy to start over, of course). Obviously, a lot of the burden is (and should be) on me, since you have made it abundantly clear that change is the norm. I voluntarily decided to test dev releases, although I must say that testing by me and others has identified a large number of issues. So just saying...

Thanks for taking the time and energy to identify this issue.

@tastybento
Copy link
Member

@SlimeDog I am very glad that you do this, thank you! Your support is critical.

@SlimeDog
Copy link
Author

Confirmed fixed in BBox 1.15.0-b1839

Shutting it down seems a bit harsh, but I guess it will get their attention. :)

@SlimeDog SlimeDog mentioned this issue Jul 16, 2020
Closed
@emilyastranova
Copy link

Problem is resolved for me as well in snapshot 1.15.0 b1846

@Baterka
Copy link

Baterka commented Sep 11, 2020 •
edited
Loading

Bug still persist for some players with Release 1.15.0 (https://github.com/BentoBoxWorld/BentoBox/releases/tag/1.15.0) on 1.16.2 PaperMC (latest build)

@tastybento
Copy link
Member

@Baterka This bug is closed and contained multiple issues. I don't know what specifically you are referring to, so please file another.

@BentoBoxWorld BentoBoxWorld locked as resolved and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tastybento tastybento

Labels
bug Something isn't working under investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Baterka @tastybento @emilyastranova @SlimeDog