Pets remain on reset

[SlimeDog]

Description

Describe the bug

On island reset or (unregister/register), pets remain on the old island, and could possibly be transferred to the new island, for advantage.

Output of /bbox version (Mandatory)

[11:29:30] [Server thread/INFO]: Running SPIGOT 1.16.1.
[11:29:30] [Server thread/INFO]: BentoBox version: 1.14.1-SNAPSHOT-b1835
[11:29:30] [Server thread/INFO]: Database: JSON
[11:29:30] [Server thread/INFO]: Loaded Game Worlds:
[11:29:30] [Server thread/INFO]: world_skyblock (SkyBlock): Overworld, [nether_color]Nether, [end_color]End
[11:29:30] [Server thread/INFO]: Loaded Addons:
[11:29:30] [Server thread/INFO]: Biomes 1.13.0-SNAPSHOT-b180 (ENABLED)
[11:29:30] [Server thread/INFO]: BSkyBlock 1.13.0-SNAPSHOT-b601 (ENABLED)
[11:29:30] [Server thread/INFO]: Challenges 0.9.0-SNAPSHOT-b420 (ENABLED)
[11:29:30] [Server thread/INFO]: ExtraMobs 1.11.0.4-SNAPSHOT-b7 (ENABLED)
[11:29:30] [Server thread/INFO]: Level 2.3.2-SNAPSHOT-b396 (ENABLED)

[Fredthedoggy]

This is similar to #1442, which was to limit dogs/cats to a specific island.

[SlimeDog]

It is vaguely related, except #1442 is about other player's pets and this issue is about my own pets.

To clarify, if I get to keep my pets after an island reset, I gain some (relatively small) advantage compared with having to acquire them through successful challenges.

[Fredthedoggy]

Yeah, but with per island pets, you would not be able to transfer pets to a new island. They would be deleted with the old one.

[SlimeDog]

Not if you unregister the player and leave the old island intact (for reference and photo ops, say).

[Fredthedoggy]

But the dog is trapped in the new island, so it won't be able to teleport to their new island. Therefore, you can leave it, and the dogs will still work if you tp back, but otherwise they are gone

[SlimeDog]

Several of my dogs transported to my new island from the one on which I was unregistered. I killed them, to play fair. That was the genesis of this issue.

[SlimeDog]

This issue may well have been caused by BSkyBlock#355. I have not observed it since that was fixed. Just a thought...

[tastybento]

This issue may well have been caused by BSkyBlock#355. I have not observed it since that was fixed. Just a thought...

No, it's unrelated. It's normal game mechanics that tamed animals will try to follow a player when the chunks are unloaded that they are in. This apparently, isn't always the case (Mojang bug), but most of the time. Depending on how long it takes before a chunk is unloaded or not when resetting an island, the island may be deleted and the entities there removed (killed). So, I'd say that it's just luck whether you get your pet or not. To fix this we need to untame all the animals on an island that is going to be reset, or kill them.

[SlimeDog]

One vote for untame, but either is fine.

[Fredthedoggy]

Just a thought, but would that mean if you reclaim the island, then your pets are all untaimed?

[SlimeDog]

Yes, but reclaim is presumably a rare event. It is not difficult to tame them again. But if the abandoned island is otherwise used, it's good that the abandoned pets aren't owned by you.

(Related: Island reset does not clear the player inventory. Should it do? If so, new issue.)

[Fredthedoggy]

I guess your right, it is a rare occurrence. just a question, do wolves get just entirely reset? Because they can't be sitting or keep a collar color if unclaimed.

Your second question:
https://github.com/BentoBoxWorld/BSkyBlock/blob/develop/src/main/resources/config.yml#L266

[SlimeDog]

Your second question:
https://github.com/BentoBoxWorld/BSkyBlock/blob/develop/src/main/resources/config.yml#L266

Perfect. Works great except: new issue posted: #1461.

So, tamed wolf and tamed cat should be added as options on reset.on-join and reset.on-leave. I assumed that wolf would be completed reset, to untamed.

[SlimeDog]

>bbox version
[08:41:55] [Server thread/INFO]: Running SPIGOT 1.16.1.
[08:41:55] [Server thread/INFO]: BentoBox version: 1.15.0-SNAPSHOT-b1847
[08:41:55] [Server thread/INFO]: Database: JSON
[08:41:55] [Server thread/INFO]: Loaded Game Worlds:
[08:41:55] [Server thread/INFO]: world_skyblock (SkyBlock): Overworld, [nether_color]Nether, [end_color]End
[08:41:55] [Server thread/INFO]: Loaded Addons:
[08:41:55] [Server thread/INFO]: Biomes 1.13.0-SNAPSHOT-b181 (ENABLED)
[08:41:55] [Server thread/INFO]: BSkyBlock 1.13.0-SNAPSHOT-b601 (ENABLED)
[08:41:55] [Server thread/INFO]: Challenges 0.8.4-SNAPSHOT-b428 (ENABLED)
[08:41:55] [Server thread/INFO]: ExtraMobs 1.11.0.4-SNAPSHOT-b7 (ENABLED)
[08:41:55] [Server thread/INFO]: Level 2.4.0-SNAPSHOT-b405 (ENABLED)

I just reset my island, and tamed wolves followed me to the new island. I assume that owned cats would have done as well, had they not been force-sitting.

[SlimeDog]

Confirmed on Spigot and Paper 1.16.4 with BentoBox 1.15.4-b1926. Thank you.