Use a different method to grab the DataObject classes. #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when all Addons were Addons and men were men, the DataObjects could be tracked using the BentoBox custom ClassLoader. However, as Addons now can be and usually are loaded using the Bukkit Classloader, this is no longer possible. However, we can track them when a Database class is instantiated and use that. This relies on Addons declaring their database objects. If they have not when the migration command is run, then obviously they cannot be transfered.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when all Addons were Addons and men were men, the DataObjects could be tracked using the BentoBox custom ClassLoader. However, as Addons now can be and usually are loaded using the Bukkit Classloader, this is no longer possible. However, we can track them when a Database class is instantiated and use that. This relies on Addons declaring their database objects. If they have not when the migration command is run, then obviously they cannot be transfered.
Fixes #2276