Feature to add VM options in addition to VM properties #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argument index for `String.format` starts from `1`. In Java 11, index `0` defaulted to the first argument provided in the order. However, in Java 17, this throws `IllegalFormatArgumentIndexException`
anishthecoder-feature-1 Conflicts: maven-osgi-package-plugin/src/main/java/at/bestsolution/maven/osgi/pack/ProductPackagePlugin.java
tomsontom
requested changes
Feb 13, 2022
Comment on lines
+80
to
+81
| product.launcherArgs.vmOptions.stream().collect(Collectors.joining(" ")) | ||
| + product.launcherArgs.vmProperties.entrySet().stream() |
There was a problem hiding this comment.
you need to add a forced space between those entries if vmOptions is not empty
Comment on lines
+98
to
+99
| product.launcherArgsWin.vmOptions.stream().collect(Collectors.joining(" ")) | ||
| + product.launcherArgsWin.vmProperties.entrySet().stream() |
There was a problem hiding this comment.
you need to add a forced space between those entries if vmOptions is not empty
Comment on lines
+115
to
+116
| product.launcherArgsOSX.vmOptions.stream().collect(Collectors.joining(" ")) | ||
| + product.launcherArgsOSX.vmProperties.entrySet().stream() |
There was a problem hiding this comment.
you need to add a forced space between those entries if vmOptions is not empty
Comment on lines
+132
to
+133
| product.launcherArgsLinux.vmOptions.stream().collect(Collectors.joining(" ")) | ||
| + product.launcherArgsLinux.vmProperties.entrySet().stream() |
There was a problem hiding this comment.
you need to add a forced space between those entries if vmOptions is not empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Java 17, sometimes the launch configuration needs to add VM options such as
--add-opens. Currently, there is no method to specify such options that get passed on directly to the launcher. This is a proposal for such an addition.