Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let have a different INSTALL_DIR and PROGRAM_DIR #2159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sergiomb2
Copy link
Contributor

Regarding issue #2157 , I noticed that -Djava.library.path= and -Dazureus.install.path are always equal but can be different , let install plugins on homedir while main jar is installed java.library.path , fix my packaging problem .

@ferdnyc
Copy link
Contributor

ferdnyc commented Nov 27, 2021

@sergiomb2

My only suggestion (bikeshedders, assemble!) would be to go with something other than INSTALL_DIR, if the example path is going to be pointed at the user's $HOME/.biglybt directory. That's not really any kind of "install" dir. CONFIG_DIR or SETTINGS_DIR or USER_PLUGINS_DIR or something like that strikes me as more descriptive, if that's where it's expected to point.

And if that's not where it's expected to point (like, say, it's pointing instead to a shared plugins path), then I'd still go with PLUGINS_DIR or something like that. PROGRAM_DIR and INSTALL_DIR sound like the exact same thing, to me.

@sergiomb2
Copy link
Contributor Author

@sergiomb2

My only suggestion (bikeshedders, assemble!) would be to go with something other than INSTALL_DIR, if the example path is going to be pointed at the user's $HOME/.biglybt directory. That's not really any kind of "install" dir. CONFIG_DIR or SETTINGS_DIR or USER_PLUGINS_DIR or something like that strikes me as more descriptive, if that's where it's expected to point.

And if that's not where it's expected to point (like, say, it's pointing instead to a shared plugins path), then I'd still go with PLUGINS_DIR or something like that. PROGRAM_DIR and INSTALL_DIR sound like the exact same thing, to me.

indeed, USER_PLUGINS_DIR is more intuitive , with USER_PLUGINS_DIR we may install plugins in our home directory and have biglybt installed on system, /usr/share/java/biglybt .

thanks for the suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants