Merge pull request toggle-corp#756 from toggle-corp/fix/lint-issues

Fix lint issues
Bihan · Apr 13, 2021 · 240b1c1 · 240b1c1
2 parents a53a79a + 6af86b8
commit 240b1c1
Show file tree

Hide file tree

Showing 11 changed files with 18 additions and 26 deletions.
diff --git a/components/General/Modalize.d.ts b/components/General/Modalize.d.ts
@@ -1,5 +1,6 @@
 import * as React from 'react';
 
+// eslint-disable-next-line @typescript-eslint/ban-types
 declare function modalize<T extends object>(
     component: (props: T) => JSX.Element,
 ): React.ReactComponent<T & { modal: React.ReactElement; initialShowModal?: boolean }>;

diff --git a/components/View/List/index.js b/components/View/List/index.js
@@ -126,7 +126,7 @@ export class NormalList extends React.Component {
         } = this.props;
 
         if (!groupKeySelector) {
-            return data.map(this.renderListItem);
+            return data.map((datum, index) => this.renderListItem(datum, index));
         }
 
         // TODO: memoize this operation

diff --git a/components/Visualization/GaugeChart/index.js b/components/Visualization/GaugeChart/index.js
@@ -2,7 +2,7 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import { select } from 'd3-selection';
 // FIXME: idk if this has a side-effect
-import { range } from 'd3-array';
+// import { range } from 'd3-array';
 import {
     arc,
     pie,

diff --git a/components/Visualization/Map/MapDownload/index.js b/components/Visualization/Map/MapDownload/index.js
@@ -92,11 +92,11 @@ class MapDownload extends React.PureComponent {
 
     render() {
         const {
-            legendContainerClassName, // capturing the prop
-            setDestroyer,
-            zoomLevel,
-            mapContainerRef,
-            mapStyle, // capturing the prop
+            legendContainerClassName, // eslint-disable-line no-unused-vars, @typescript-eslint/no-unused-vars, max-len
+            setDestroyer, // eslint-disable-line no-unused-vars, @typescript-eslint/no-unused-vars
+            zoomLevel, // eslint-disable-line no-unused-vars, @typescript-eslint/no-unused-vars
+            mapContainerRef, // eslint-disable-line no-unused-vars, @typescript-eslint/no-unused-vars, max-len
+            mapStyle, // eslint-disable-line no-unused-vars, @typescript-eslint/no-unused-vars
             ...otherProps
         } = this.props;
         const {

diff --git a/components/Visualization/PieChart/index.js b/components/Visualization/PieChart/index.js
@@ -13,7 +13,7 @@ import Responsive from '../../General/Responsive';
 
 import styles from './styles.scss';
 
-// eslint-disable-next-line no-unused-vars
+// eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars
 const dummy = transition;
 
 const propTypes = {

diff --git a/utils/common.d.ts b/utils/common.d.ts
@@ -1,4 +1,6 @@
+// eslint-disable-next-line import/prefer-default-export
 export declare function getObjectChildren(
+    // eslint-disable-next-line @typescript-eslint/ban-types
     obj: object,
     // FIXME: handle undefined in reverseRoute
     keys: (undefined| number | string)[],

diff --git a/v2/Input/DigitalInput/index.tsx b/v2/Input/DigitalInput/index.tsx
@@ -1,7 +1,6 @@
 import React from 'react';
 import {
     padStart,
-    isFalsyString,
     isTruthyString,
     _cs,
 } from '@togglecorp/fujs';

diff --git a/v2/Input/NepaliDateInput/Calendar/index.tsx b/v2/Input/NepaliDateInput/Calendar/index.tsx
@@ -38,7 +38,7 @@ const YearMode = (props: YearModeProps) => {
     const maxYear = BS.getMaxYmd().getYear();
 
     const cells = useMemo(
-        () => [...new Array(maxYear - minYear + 1)],
+        () => [...new Array((maxYear - minYear) + 1)],
         [maxYear, minYear],
     );
 

diff --git a/v2/Input/SelectInput/index.tsx b/v2/Input/SelectInput/index.tsx
@@ -18,10 +18,6 @@ interface DefaultItem {
     label: string;
 }
 
-interface State<K> {
-    searchValue?: string;
-}
-
 /*
 # Feature
 - Auto-scroll to selected item on popup open
@@ -40,7 +36,7 @@ interface State<K> {
 - Show values that are invalid (tally with current options)
 */
 
-function filterAndSearch<T, K>(
+function filterAndSearch<T>(
     options: T[],
     labelSelector: (datum: T) => string | number,
     searchValue: string,

diff --git a/v2/View/List/index.tsx b/v2/View/List/index.tsx
@@ -21,7 +21,7 @@ interface BaseProps<D, P, K extends OptionKey> {
     rendererParams: (key: K, datum: D, index: number, data: D[]) => P;
 }
 
-interface GroupOptions<D, P, K extends OptionKey, GP, GK extends OptionKey> {
+interface GroupOptions<D, GP, GK extends OptionKey> {
     groupComparator?: (a: GK, b: GK) => number;
     groupKeySelector(datum: D): GK;
     groupRenderer: React.ComponentType<GP>;
@@ -35,17 +35,17 @@ interface NoGroupOptions {
 }
 
 export type ListProps<D, P, K extends OptionKey, GP, GK extends OptionKey> = (
-    BaseProps<D, P, K> & (GroupOptions<D, P, K, GP, GK> | NoGroupOptions)
+    BaseProps<D, P, K> & (GroupOptions<D, GP, GK> | NoGroupOptions)
 );
 
 export type GroupedListProps<D, P, K extends OptionKey, GP, GK extends OptionKey> = (
-    BaseProps<D, P, K> & GroupOptions<D, P, K, GP, GK>
+    BaseProps<D, P, K> & GroupOptions<D, GP, GK>
 );
 
 function hasGroup<D, P, K extends OptionKey, GP, GK extends OptionKey>(
     props: ListProps<D, P, K, GP, GK>,
-): props is (BaseProps<D, P, K> & GroupOptions<D, P, K, GP, GK>) {
-    return !!(props as BaseProps<D, P, K> & GroupOptions<D, P, K, GP, GK>).grouped;
+): props is (BaseProps<D, P, K> & GroupOptions<D, GP, GK>) {
+    return !!(props as BaseProps<D, P, K> & GroupOptions<D, GP, GK>).grouped;
 }
 
 function GroupedList<D, P, K extends OptionKey, GP, GK extends OptionKey>(
@@ -160,5 +160,3 @@ function List<D, P, K extends OptionKey, GP, GK extends OptionKey>(
 List.defaultProps = {
     data: [],
 };
-
-export default List;
diff --git a/v2/View/Message/index.tsx b/v2/View/Message/index.tsx
@@ -32,10 +32,6 @@ interface Props {
     resizeFactor: number;
 }
 
-interface State {
-    show: boolean;
-}
-
 function Message(props: Props) {
     const {
         maxFontSize,