Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RevitMarkingElements: Создание плагина #141

Merged
merged 19 commits into from
Feb 17, 2025
Merged

RevitMarkingElements: Создание плагина #141

merged 19 commits into from
Feb 17, 2025

Conversation

KGubin
Copy link
Contributor

@KGubin KGubin commented Jan 10, 2025 •
edited
Loading

Создание плагина, реализация следующего функционала:

  • Нумерация выделенных линией элементов на активном виде.
  • Нумерация всех элементов имеющих свойство марка на активном виде.

@KGubin KGubin requested a review from dosymep January 10, 2025 07:13
dosymep

This comment was marked as resolved.

Sign in to view

@KGubin KGubin requested a review from dosymep January 13, 2025 09:16
dosymep
dosymep requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@dosymep dosymep left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • посмотри код платформы, какие в ней есть методы, изучи их
  • так же перепроверь задание, которое ты делал
  • отсортируй везде члены класса, согласно нашему код стайлу

@KGubin KGubin requested a review from dosymep January 15, 2025 13:13
dosymep
dosymep requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@dosymep dosymep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • посмотри код платформы, какие в ней есть методы, изучи их
  • так же перепроверь задание, которое ты делал
  • отсортируй везде члены класса, согласно нашему код стайлу

@KGubin KGubin requested a review from dosymep January 17, 2025 05:43
dosymep
dosymep requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@dosymep dosymep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • посмотри код платформы, какие в ней есть методы, изучи их
  • так же перепроверь задание, которое ты делал

@KGubin KGubin requested a review from dosymep January 27, 2025 13:38
@KGubin KGubin requested a review from dosymep February 5, 2025 07:48
@vlastroG vlastroG self-requested a review February 5, 2025 12:33
vlastroG
vlastroG requested changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@vlastroG vlastroG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сверь алгоритм работы плагина со своей реализацией

@KGubin KGubin requested a review from vlastroG February 6, 2025 11:17
dosymep
dosymep requested changes Feb 7, 2025
View reviewed changes
@KGubin KGubin requested a review from dosymep February 7, 2025 14:06
@KGubin KGubin requested a review from dosymep February 10, 2025 10:43
@KGubin KGubin requested a review from dosymep February 11, 2025 09:02
dosymep
dosymep requested changes Feb 13, 2025
View reviewed changes
Copy link
Member

@dosymep dosymep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не забудь поправить конфликты

@KGubin KGubin requested a review from dosymep February 13, 2025 08:59
@dosymep dosymep merged commit debb916 into master Feb 17, 2025
2 checks passed
@dosymep dosymep deleted the KGubin/RevitMarkingElements branch February 17, 2025 06:19
@dosymep dosymep mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dosymep dosymep dosymep approved these changes

@vlastroG vlastroG Awaiting requested review from vlastroG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KGubin @dosymep @vlastroG