-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RevitKrChecker: Добавлен плагин "Проверить модель" #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… останавливающие проверки
…танавливающие проверки
…кой параметров материала
…лу. Добавлены проверки соответствия по словарю
dosymep
requested changes
Feb 3, 2025
src/RevitKrChecker/Models/Check/TemplatesCompareElemParamsCheck.cs
Outdated
Show resolved
Hide resolved
vlastroG
requested changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Поправь стиль кода: фигурные скобки, отступы, xaml.
Также настоятельно рекомендую дублирующиеся куски кода объединять и выносить в какое-то одно место. Потом легче будет вносить изменения. (Сейчас оставь как есть)
src/RevitKrChecker/Models/Check/TemplatesCompareMaterialParamsCheck.cs
Outdated
Show resolved
Hide resolved
dosymep
requested changes
Feb 13, 2025
dosymep
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Плагин позволяет:
Для запуска: