Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sorting field types to 64 bit long #279

Closed
wants to merge 38 commits into from

Conversation

hextraza
Copy link
Contributor

No description provided.

@bbimber
Copy link
Contributor

bbimber commented Jun 19, 2024

@hextraza: this seems fine, but one question. if we're going to treat every int field like a long (which is what i think this does), should the DISCVRseq code index every INT as a LONG: https://github.com/BimberLab/DISCVRSeq/blob/dc81abc6b8e9ae2936415145c7d76dccdca6f2e9/src/main/java/com/github/discvrseq/walkers/VcfToLuceneIndexer.java#L443. If I understand it, we are indexing genomicPosition as LONG, but everything else as INT

@bbimber
Copy link
Contributor

bbimber commented Jun 19, 2024

Also, we should target 23.11 so we can deploy to mGAP now.

@hextraza
Copy link
Contributor Author

@hextraza: this seems fine, but one question. if we're going to treat every int field like a long (which is what i think this does), should the DISCVRseq code index every INT as a LONG: https://github.com/BimberLab/DISCVRSeq/blob/dc81abc6b8e9ae2936415145c7d76dccdca6f2e9/src/main/java/com/github/discvrseq/walkers/VcfToLuceneIndexer.java#L443. If I understand it, we are indexing genomicPosition as LONG, but everything else as INT

the line targets numericQueryParserFields which is only used to look up the type of sorting fields-- all sorting fields are indexed as 64 bit long in DiscvrSeq. actual values displayed in the table are all parsed as ints, instead. if we wanted to display genomicPosition it'd have to be parsed in the API as a long instead of as an int, but it isn't a value displayed on the client side afaik

I can rebase this on 23.11.

labkey-matthewb and others added 25 commits June 20, 2024 11:47
* Add LRUQueryCache

* Custom query caching policy

* Query strategy works on BooleanQuery with MatchAllDocs predicate

* Use proper Cache and add action to report cache info

* Improve handling of lucene cache

* Add code to cache the first page of each mGAP JBrowse session

* Add logging and clear cache prior to adding default query

---------

Co-authored-by: Sebastian Benjamin <[email protected]>
Co-authored-by: bbimber <[email protected]>
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@hextraza hextraza closed this Jun 20, 2024
@hextraza hextraza deleted the 23.4_fb_sortingLongFix branch June 20, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants