Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed load of nested relationships #590

Open
wants to merge 5 commits into
base: 8.x
Choose a base branch
from
Open

Fixed load of nested relationships #590

wants to merge 5 commits into from

Conversation

binaryk
Copy link
Collaborator

@binaryk binaryk commented Sep 30, 2023

Fixed

@what-the-diff
Copy link

what-the-diff bot commented Sep 30, 2023

PR Summary

  • Introduction of conditional logic for handling data
    The system's ability to process related data has been enhanced in the RelatedCollection.php file. This change aids in more flexible handling of data which significantly improves the software's adaptability to various use case scenarios.

  • Enhancements to the RelatedDto.php
    The RelatedDto.php file now includes a new public property, $query, which broadens scope for querying the system. Also, a new method isDeepRelation has been introduced to probe deeply nested relations in the data.

  • Refinement of code commments
    The comments in RestResponse.php, ValidatingTrait.php, CompanyPolicy.php, and MailTracking.php files have been reviewed and deemed unnecessary for the functioning of the code, hence we have tidied up the code by removing these comments.

  • Temporary disablement of a method
    In Repository.php a certain method has been temporarily switched off by commenting it out. This suggests a potential review or replacement of this part of the code in near future.

  • Streamlining mail tracking methods
    The methods dealing with email handling in the MailTracking.php file have been streamlined. Redundant parameters in the assertEmailEquals, assertEmailContains, assertEmailSubject, assertEmailTo, assertEmailFrom, and getEmail methods have been removed. This edit boosts the efficiency in the email handling process and may make debugging easier.

  • Improved testing
    A new testing method titled test_can_load_deep_relationships has been incorporated in the IndexRelatedFeatureTest.php file. This ensures better and robust testing capabilities particularly for deep relational data in our software system.

@binaryk binaryk changed the title ## Fixed fixing load of nested relationships Fixed load of nested relationships Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant