Skip to content

Commit

Permalink
Update site changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
Brandon Tilley committed Jan 30, 2015
1 parent 5d881bd commit 8eea48c
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions site/contents/changelog.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,17 @@ template: page.ejs
Changelog
=========

Version 1.5.2
-------------

* Upgrade to Lo-Dash 3.x
* Fix minor typo in mixin warnings

Version 1.5.1
-------------

* Watch stores in `componentDidMount` instead of `componentWillMount` to make it harder to leak memory on the server

Version 1.5.0
-------------

Expand Down

7 comments on commit 8eea48c

@svnlto
Copy link

@svnlto svnlto commented on 8eea48c Feb 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BinaryMuse you should bump the minor version for such a change (changing from lodash 2.x to 3.x). esp because it's breaking things.

@BinaryMuse
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svnlto What is breaking? Lo-Dash is only used internally and is not exposed to the user; Fluxxor's public API did not change at all.

@svnlto
Copy link

@svnlto svnlto commented on 8eea48c Feb 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a simple component test using jestand that break using 1.5.2:

TypeError: 
/home/jenkins/workspace/redacted/src/app/components/contacts/__tests__/header-test.js: 
/home/jenkins/workspace/redacted/src/app/components/contacts/header.js: 
/home/jenkins/workspace/redacted/src/app/components/starred/index.js: 
/home/jenkins/workspace/redacted/node_modules/fluxxor/index.js: 
/home/jenkins/workspace/redacted/node_modules/fluxxor/lib/dispatcher.js: 
/home/jenkins/workspace/redacted/node_modules/fluxxor/node_modules/lodash-node/modern/lang/clone.js: 
/home/jenkins/workspace/redacted/node_modules/fluxxor/node_modules/lodash-node/modern/internal/baseClone.js:
/home/jenkins/workspace/redacted/node_modules/fluxxor/node_modules/lodash-node/modern/internal/baseForOwn.js:
/home/jenkins/workspace/redacted/node_modules/fluxxor/node_modules/lodash-node/modern/object/keys.js:
/home/jenkins/workspace/redacted/node_modules/fluxxor/node_modules/lodash-node/modern/lang/isNative.js: Cannot call method 'replace' of undefined

@BinaryMuse
Copy link
Owner

@BinaryMuse BinaryMuse commented on 8eea48c Feb 3, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xMartin
Copy link

@xMartin xMartin commented on 8eea48c Feb 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, it seems to happen if a dependency of a component requires Fluxxor.

Check this demo project: https://github.com/xMartin/fluxxor-issue

@BinaryMuse
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's really quite unfortunate. Thanks for the repro case, it helped a ton.

It looks like it's choking on object/keys down in lang/isNative, which is used by a bunch of the other functions (not just object/clone). I'm not sure why. Adding <rootDir>/node_modules/fluxxor to unmockedModulePathPatterns fixes the issue in the demo project, as does adding jest.dontMock("fluxxor") to the test. Not sure if that will affect your other tests or not, but might be a starting point.

I'm not really familiar with the Jest internals and don't really understand why this is an issue, but I'll continue to look into it. Let me know if the workaround above works for you, and I'll continue to look into a more permanent fix.

@BinaryMuse
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this to #101

Please sign in to comment.