Upgrade examples/react-router to use react-router 1.0-rc1 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, @andrewslater. I'm going to wait for React Router 1.0 final to hit to update the site and example, but this will be useful for the update. |
|
I get the same error after migrating to react-router 1.0.0-rc1 |
|
See this comment for an explanation of the context issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the react-router example to use react-router 1.0-rc1
Was trying to reproduce the issue I'm seeing as documented in #141 however even after upgrading to react-router 1.0-rc1 I am not able to reproduce the issue where I see
when injecting fluxxor into my router components in another app I'm working on. Nevertheless this code to migrate to react-router 1.0-rc1 may be useful to the Fluxxor project.