thjs-63: * danger and commitlint configs into typescript

.eslintrc.yml

@@ -141,13 +141,9 @@ rules:
 
 overrides:
   - files:
-      - project.config.cjs
-      - commitlint.config.cjs
-      - dangerfile.cjs
-    parserOptions:
-      sourceType: commonjs
-    env:
-      node: true
+      - project.config.ts
+      - commitlint.config.ts
+      - dangerfile.ts
     rules:
       'import/no-default-export':
         - off

.github/workflows/ci-pr.yml

@@ -44,7 +44,7 @@ jobs:
 
       - name: Lint Commits
         run: |
-          npx commitlint --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }} --verbose -g ./commitlint.config.cjs
+          npx commitlint --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }} --verbose -g ./commitlint.config.ts
 
       - name: Add Folder Labels
         uses: actions/labeler@v4

commitlint.config.cjs → commitlint.config.ts

@@ -1,4 +1,6 @@
-const { ProjectPrefix } = require('./project.config.cjs');
+import { UserConfig } from '@commitlint/types';
+
+import { ProjectPrefix } from './project.config';
 
 const COMMIT_MODIFIERS = ['+', '*', '-'];
 const COMMIT_MESSAGE_REGEXP = new RegExp(
@@ -19,7 +21,7 @@ Examples:
   - ${ProjectPrefix.APP}-12: * docker homework
   - production: - comments in ui/ux homework`;
 
-const configuration = {
+const configuration: UserConfig = {
   parserPreset: {
     parserOpts: {
       headerPattern: COMMIT_MESSAGE_REGEXP,
@@ -45,4 +47,4 @@ const configuration = {
   }
 };
 
-module.exports = configuration;
+export default configuration;

dangerfile.cjs → dangerfile.ts

@@ -1,11 +1,29 @@
-const { danger, fail } = require('danger');
-
-const { ProjectPrefix } = require('./project.config.cjs');
+import {
+  danger,
+  fail,
+  type GitHubPRDSL as LibraryGitHubDSL,
+  GitHubMergeRef,
+  GitHubRepo,
+  GitHubDSL
+} from 'danger';
+
+import { ProjectPrefix } from './project.config';
+
+type GitHubPRDSL = LibraryGitHubDSL & {
+  head: GitHubMergeRef & {
+    repo: GitHubRepo & {
+      has_projects: boolean;
+    };
+  };
+  milestone: Record<string, unknown> | null;
+  labels: unknown[];
+  project_id: string | null;
+};
 
 const BranchPrefix = {
   TASK: 'task',
   FIX: 'fix'
-};
+} as const;
 
 const DangerConfig = {
   TITLE: {
@@ -34,17 +52,17 @@ const DangerConfig = {
   }
 };
 
-const pr = danger.github.pr;
+const { pr } = danger.github as GitHubDSL & Record<'pr', GitHubPRDSL>;
 
-const checkAssignees = () => {
+const checkAssignees = (): void => {
   const hasAssignees = Boolean(pr.assignee);
 
   if (!hasAssignees) {
     fail('This pull request should have at least one assignee.');
   }
 };
 
-const checkTitle = titlePattern => {
+const checkTitle = (titlePattern: RegExp): void => {
   const isTitleValid = titlePattern.test(pr.title);
 
   if (!isTitleValid) {
@@ -56,15 +74,15 @@ const checkTitle = titlePattern => {
   }
 };
 
-const checkLabels = () => {
+const checkLabels = (): void => {
   const hasLabels = pr.labels.length > 0;
 
   if (!hasLabels) {
     fail('This pull request should have at least one label.');
   }
 };
 
-const checkBranch = branchPattern => {
+const checkBranch = (branchPattern: RegExp): void => {
   const isBranchValid = branchPattern.test(pr.head.ref);
 
   if (!isBranchValid) {
@@ -76,7 +94,7 @@ const checkBranch = branchPattern => {
   }
 };
 
-const applyDanger = () => {
+const applyDanger = (): void => {
   if (DangerConfig.TITLE.IS_REQUIRED) {
     checkTitle(DangerConfig.TITLE.PATTERN);
   }

package.json

@@ -5,7 +5,6 @@
     "node": "18.x.x",
     "npm": "9.x.x"
   },
-  "type": "module",
   "workspaces": [
     "client",
     "server",
@@ -48,6 +47,6 @@
   },
   "simple-git-hooks": {
     "pre-commit": "npx lint-staged",
-    "commit-msg": "npx commitlint --edit $1 -c -g ./commitlint.config.cjs"
+    "commit-msg": "npx commitlint --edit $1"
   }
 }

project.config.cjs → project.config.ts

@@ -1,6 +1,6 @@
 const ProjectPrefix = {
   APP: 'thjs',
   ENVIRONMENTS: ['development', 'production']
-};
+} as const;
 
-module.exports = { ProjectPrefix };
+export { ProjectPrefix };

tsconfig.json

@@ -1,5 +1,4 @@
 {
-  "exclude": ["commitlint.config.ts"],
   "compilerOptions": {
     "strict": true,
     "noUncheckedIndexedAccess": true,