-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched absolute to relative additional radius #382
base: master
Are you sure you want to change the base?
Conversation
WIP: adapt all the tests |
I agree with the approach you proposed @nicogno. I'd be in favour however setting the 'additional_radius_scaling' parameter as an input argument to the function. It can be let to take a default value (i.e., 1.03 as you propose in your code changes) yet permit a user to tailor the value to their needs - instead of restricting it to a fixed parameter value, isn't it? |
The force is a function so it would have to be a member variable together with some appropriate |
Adapted tests and made the value adjustable by the user |
Quality Gate passedIssues Measures |
Changes look all good to me. Just wondering, have you checked if/how it affects the demos? |
Larger virtual cell radii are currently considered when an interaction force is computed. This PR suggests switching to a virtual radius that is relative to the actual cell radius.
This might affect the demos where cell interaction is involved.