Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved Issue #61 #70

Merged
merged 3 commits into from
Jan 9, 2019
Merged

Solved Issue #61 #70

merged 3 commits into from
Jan 9, 2019

Conversation

Enoinoo
Copy link
Contributor

@Enoinoo Enoinoo commented Jan 2, 2019

Moved all queries and mutations to files under /web/queries

Copy link
Contributor

@Dieff Dieff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are just two small things that you might want to change. Other than that, looks good. I think it will be ready to merge once you look at those. IDK if we can merge it without @iamandyk tho.

Also, there are a few places where you made custom Query or Mutation components but didn't give them any new types because the types weren't defined yet, like CourseQueryComp. Eventually it would be great to have interfaces for the variables and result of those queries, so class CourseQueryComp extends Query<IQueryResultData, IQueryVariables> {} but we haven't defined those types yet. I guess that should be another issue though.

web/queries/courseQueries.tsx Outdated Show resolved Hide resolved
web/testFunction.js Outdated Show resolved Hide resolved
@Enoinoo
Copy link
Contributor Author

Enoinoo commented Jan 8, 2019

I can open another issue to create interfaces for variables and results of the queries and work on that. Should I?

For this pull request though, I have updated the branch with the changes you requested!

@Dieff
Copy link
Contributor

Dieff commented Jan 8, 2019

Looks good. I think Andy has some ideas about this and also #73 deals with it so I think we can wait on defining the new Interfaces for the rest of the queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants