Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how to comply with the FAIR chemical structures specification #658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

egonw
Copy link
Contributor

@egonw egonw commented Oct 31, 2023

Internal reference

#657 and #639

Description

A the BioHackathon Europe 2022 this was discussed with @AlasdairGray and Evan Bolton. Since then, the properties have been made optional, but the explanation in the description never got in.

Motivation and context

  • The explanation should explain how to use Bioschemas to provide data needed to be a "FAIR chemical structure".

Have these been tested?

No.

What should reviewers focus on?

That the JSON is correct. I tried using the DDE, which sort of worked, but the JSON was so much different, even though I did start with the DDE version of 0.7-DRAFT that I went for the JSON in this repo.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change which adds new content)
  • Modified content (non-breaking change which modifies existing content)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Future TO-DOs

  • e.g. Once reviewed, check webpage update...

@gtsueng
Copy link
Contributor

gtsueng commented Oct 31, 2023

The JSON file above displays fine in the DDE, but getting it to propagate to the website is another story (see #643)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants