-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster CI #95
Merged
multimeric
merged 19 commits into
BioimageAnalysisCoreWEHI:master
from
multimeric:faster-ci
Nov 19, 2024
Merged
Faster CI #95
multimeric
merged 19 commits into
BioimageAnalysisCoreWEHI:master
from
multimeric:faster-ci
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attice into faster-ci
pr4deepr
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great troubleshooting...
Thats a massive speed up!
Happy for this to be merged.. The test time was a concern till now, so I'm glad you sorted this out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #94.
Sped up CI by swapping out
RBC_tiny.czi
withLLS7_t1_ch1.czi
for all workflow tests. For some reason this combination of workflow + large image really makes the worker hang. I suspect it might relate to available memory on the CI worker, because it doesn't run slowly on my machine.Also fixed an unrelated issue where arbitrary numpy arrays didn't have proper axis labels, which came up due to the addition of a new test.
Test runtime is down from ~42 minutes to ~1 minute.