Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Hallucinations don't print to newscasters #1534

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

NaakaKo
Copy link
Collaborator

@NaakaKo NaakaKo commented Nov 14, 2023

Original PR: https://api.github.com/repos/tgstation/tgstation/pulls/79711

About The Pull Request

Fixes #79709

I thought it was clever to use priority_announce for the hallucinations, as means for maintaining parity, unfortunately the proc is not pure and prints reports to the newscasters. Oopsie.

This makes it so only reports sent to all players are printed to newscasters.

Changelog

🆑 Melbert
fix: Fixes hallucination and encrypted announcements printing to the Newscaster.
/:cl:

MrMelbert and others added 2 commits November 14, 2023 20:52
## About The Pull Request

Fixes #79709 

I thought it was clever to use `priority_announce` for the
hallucinations, as means for maintaining parity, unfortunately the proc
is not pure and prints reports to the newscasters. Oopsie.

This makes it so only reports sent to all players are printed to
newscasters.

## Changelog

:cl: Melbert
fix: Fixes hallucination and encrypted announcements printing to the
Newscaster.
/:cl:
@NaakaKo NaakaKo added the Upstream PR Merged Used by the mirror bot. label Nov 14, 2023
@CliffracerX CliffracerX merged commit 1bfb887 into master Nov 14, 2023
2 checks passed
github-actions bot added a commit that referenced this pull request Nov 14, 2023
@CliffracerX CliffracerX deleted the upstream-merge-79711 branch November 22, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Upstream PR Merged Used by the mirror bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants