Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fix last words being double-encoded when done from the alert popup #2541

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

NaakaKo
Copy link
Collaborator

@NaakaKo NaakaKo commented Feb 10, 2024

Original PR: https://api.github.com/repos/tgstation/tgstation/pulls/81386

About The Pull Request

Fixes succumb last words, when typed in the tgui input popup, being double-encoded/sanitized, resulting in things like this:
image

Upstream port of Monkestation/Monkestation2.0#1182

Why It's Good For The Game

This bug is annoying and makes text uglier and less readable. Also, bugs are bad. Do I even need to fill this part out for a blatant bugfix?

Changelog

🆑
fix: Fix succumb last words being double-encoded (i.e i'm becoming i'lm)
/:cl:

Absolucy and others added 2 commits February 10, 2024 21:50
…#81386)

## About The Pull Request

Fixes succumb last words, when typed in the tgui input popup, being
double-encoded/sanitized, resulting in things like this:

Upstream port of
Monkestation/Monkestation2.0#1182

## Why It's Good For The Game

This bug is annoying and makes text uglier and less readable. Also, bugs
are bad. Do I even need to fill this part out for a blatant bugfix?
@NaakaKo NaakaKo added the Upstream PR Merged Used by the mirror bot. label Feb 10, 2024
@CliffracerX CliffracerX merged commit ac89ffe into master Feb 11, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Upstream PR Merged Used by the mirror bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants