[MIRROR] Makes robotic talk use GetVoice for carbons, fixing voice changer issue #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue (#81901) ## About The Pull Request I noticed that when using a chameleon set and agent ID to change my voice and then using the binary encryption key to talk over binary, it would actually show as "Real Name (as ID)" rather than "ID" as expected. Looking into the code, this seemed to be because robotic talk would use `name` rather than getting the voice of the speaker, which is set to the *visible name* of the speaker, leading to it using the visible name rather than their voice. This pr changes it to use `GetVoice` to have a result consistent with regular comms. ## Why It's Good For The Game When you use a chameleon mask with an agent ID it lets you mask your voice over comms even if your face isn't fully covered, it's your voice after all, but over robotic comms it cares about your visible name rather than your voice even though you're still talking into a headset. This pr makes it consistent with the behaviour of voice changing over regular comms. ## Changelog :cl: fix: When a carbon talks over robotic it uses their voice instead of visible name. Meaning, voice changers work like they do over other comms regardless of face covering. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR:
https://api.github.com/repos/tgstation/tgstation/pulls/81901About The Pull Request
I noticed that when using a chameleon set and agent ID to change my voice and then using the binary encryption key to talk over binary, it would actually show as "Real Name (as ID)" rather than "ID" as expected.
Looking into the code, this seemed to be because robotic talk would use
namerather than getting the voice of the speaker, which is set to the visible name of the speaker, leading to it using the visible name rather than their voice.This pr changes it to use
GetVoiceto have a result consistent with regular comms.Why It's Good For The Game
When you use a chameleon mask with an agent ID it lets you mask your voice over comms even if your face isn't fully covered, it's your voice after all, but over robotic comms it cares about your visible name rather than your voice even though you're still talking into a headset.
This pr makes it consistent with the behaviour of voice changing over regular comms.
Changelog
🆑
fix: When a carbon talks over robotic it uses their voice instead of visible name. Meaning, voice changers work like they do over other comms regardless of face covering.
/:cl: